Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch-requests): real ip header should be overridden #6251

Merged
merged 1 commit into from Feb 7, 2022
Merged

fix(batch-requests): real ip header should be overridden #6251

merged 1 commit into from Feb 7, 2022

Conversation

spacewander
Copy link
Member

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander marked this pull request as ready for review February 7, 2022 01:10
@zaunist
Copy link
Contributor

zaunist commented Feb 7, 2022

It confused me, if real ip can be overriden, why the name real ip? What the difference between it and x-forwarded-for ?

@spacewander spacewander merged commit 48e8a1e into apache:master Feb 7, 2022
@spacewander spacewander deleted the fbr branch February 7, 2022 01:57
spacewander added a commit to spacewander/incubator-apisix that referenced this pull request Feb 7, 2022
@spacewander
fix(batch-requests): real ip header should be overridden (apache#6251)
26b8b6e
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Feb 7, 2022
@spacewander @bzp2010
fix(batch-requests): real ip header should be overridden (apache#6251)
9c60d1c
bzp2010 pushed a commit to bzp2010/apisix that referenced this pull request Feb 7, 2022
@spacewander @bzp2010
fix(batch-requests): real ip header should be overridden (apache#6251)
42c630f
@leslie-tsang leslie-tsang mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spacewander @zaunist @membphis @tzssangglass