Fix XSS in Hide navigation items feature

Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
phpmyadmin · Jun 21, 2014 · daa98d0 · daa98d0
1 parent 4bb85f5
commit daa98d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/libraries/navigation/Navigation.class.php b/libraries/navigation/Navigation.class.php
@@ -189,9 +189,9 @@ public function getItemUnhideDialog($dbName, $itemType = null, $tableName = null
                         $html .= '<td style="width:80px"><a href="navigation.php?'
                             . PMA_URL_getCommon()
                             . '&unhideNavItem=true'
-                            . '&itemType=' . $t
-                            . '&itemName=' . urldecode($hiddenItem)
-                            . '&dbName=' . urldecode($dbName) . '"'
+                            . '&itemType=' . urlencode($t)
+                            . '&itemName=' . urlencode($hiddenItem)
+                            . '&dbName=' . urlencode($dbName) . '"'
                             . ' class="unhideNavItem ajax">'
                             . PMA_Util::getIcon('lightbulb.png', __('Show'))
                             .  '</a></td>';

diff --git a/libraries/navigation/Nodes/Node_DatabaseChild.class.php b/libraries/navigation/Nodes/Node_DatabaseChild.class.php
@@ -32,9 +32,9 @@ public function getHtmlForControlButtons()
                 . '<a href="navigation.php?'
                 . PMA_URL_getCommon()
                 . '&hideNavItem=true'
-                . '&itemType=' . urldecode($this->getItemType())
-                . '&itemName=' . urldecode($item)
-                . '&dbName=' . urldecode($db) . '"'
+                . '&itemType=' . urlencode($this->getItemType())
+                . '&itemName=' . urlencode($item)
+                . '&dbName=' . urlencode($db) . '"'
                 . ' class="hideNavItem ajax">'
                 . PMA_Util::getImage('lightbulb_off', __('Hide'))
                 . '</a></span>';