Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Use the last fetched time for matching multiple dictionaries
Currently, when there are multiple matching dictionaries and each
"match" option has the same length, Chrome will use the dictionary with
the latest `response_time`. But the `response_time` is not updated when
the dictionary is fetched again from the HTTP Cache.
This behavior is inconsistent with the specification. The specification
says: "Given equivalent destination and match length precedence, the
most recently fetched dictionary takes precedence."
https://www.ietf.org/archive/id/draft-ietf-httpbis-compression-dictionary-03.html#name-multiple-matching-dictionar
To fix this, this cl introduces a new field `last_fetch_time` in
Shared Dictionary storages including SQL database. This field is updated
when the dictionary is fetched from the HTTP Cache. And
GetMatchingDictionaryFromDictionaryInfoMap() method will use the field
instead of `response_time`.
Note: This CL changes the version of the shared dictionary database
scheme to V3. Data from the V2 schema will not be migrated to the new V3
schema.
Bug: 40255884
Change-Id: If13adb96468ac3878b27f4ccc108deb698e89a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480518
Reviewed-by: Patrick Meenan <pmeenan@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292884}
[Android][Passwords] Cleanup RecoverFromNeverSaveAndroid flag
Bug: 40275628
Change-Id: I081b96d38e73292f4c86b1e5724277884eb8ecca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5489240
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Adem Derinel <derinel@google.com>
Cr-Commit-Position: refs/heads/main@{#1292883}
Roll ChromeOS Atom AFDO profile from 126-6422.5-1713781547-benchmark-126.0.6438.0-r1 to 126-6422.5-1713781547-benchmark-126.0.6440.0-r2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: I98780f3a9ac3dda6b3ec70750c6b0f562e05bb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493442
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292882}
Introduce ServiceWorkerContainerHost::DispatchExtendableMessageEvent
Preparation for moving `service_worker_host()` to
`ServiceWorkerContainerHostForServiceWorker` and
removing `IsContainerForServiceWorker()`.
Bug: 336154571
Change-Id: I741afa05709553e377616b4f61a78ceb8dd49d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481707
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292881}
Introduce ServiceWorkerContainerHost::Update
Preparation for moving `service_worker_host()` to
`ServiceWorkerContainerHostForServiceWorker` and
removing `IsContainerForServiceWorker()`.
The `ExecuteUpdate()` arguments are trimmed:
- `context` -> previously it was
`ServiceWorkerRegistrationObjectHost::context_` and
after this CL `ServiceWorkerRegistration::context_` is used,
which should be the same.
- `registration_id` ->
`ServiceWorkerRegistrationObjectHost::registration_->id()`
(both `registration_` and `id()` are const)
- `force_bypass_cache` -> always false
- `skip_script_comparison` -> always false
- `callback` and `status` ->
`blink::mojom::ServiceWorkerRegistrationObjectHost::UpdateCallback`
is called directly.
Bug: 336154571
Change-Id: I0cc24faec6dfa66d5fce585d9eb9d62d31991dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479500
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292880}
[LCPP] Refactoring: move LCPP code out of ResourcePrefetchPredictor
This CL moves almost LCPP related code from ResourcePrefetchPredictor
to lcp_critical_path_predictor_util.cc for improving ownership.
Bug: 328487899
Change-Id: I69e8dba962fc916c00e7e24d6d920188f5edb295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486900
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292879}
Allow loading third-party modules in GPU sandbox
"--allow-third-party-modules" is useful for developers to test dev build
of GPU drivers within the GPU sandbox on Windows platform.
Bug: 41482351
Change-Id: Iaa6c50cf175cc4bfdedc8d8c5d49293f9310863f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5337323
Commit-Queue: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292878}
Roll Website from 921a58e45b8a to b3d5ab866305 (2 revisions)
https://chromium.googlesource.com/website.git/+log/921a58e45b8a..b3d5ab866305
2024-04-25 yzshen@chromium.org Mojo docs: Update g3doc links to chromium.org links.
2024-04-25 yzshen@chromium.org Mojo doc: update a link to point to correct destination
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dpranke@google.com
Change-Id: I74c94890d3458925243eb31bee7394d8e0ec1e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493146
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292877}
Use std::string_view in ParseFileURL.
As a drive-by, this CL uses testing::AssertionResult in one of the
testing methods in url_parse_unittest.cc to get better test errors.
Bug: 325408566
Change-Id: Idd0ea0957c069fc5127c03202a960ae0e54756d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370588
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1292876}
ozone: remove cache_texture_in_ozone_backing
OzoneImageBacking always caches textures on per context basis.
Thus, this workaround control can be removed.
Bug: 40281108
Change-Id: I9eb99da113bdfc112650d5c6aba0e9bf772f3f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488078
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292875}
Roll Skia from 518a85e0192e to 4aa03c55a0a2 (2 revisions)
https://skia.googlesource.com/skia.git/+log/518a85e0192e..4aa03c55a0a2
2024-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e6a1f0f0732a to 07bdf2c05272 (10 revisions)
2024-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e6a1f0f0732a to 07bdf2c05272
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jvanverth@google.com
Change-Id: I3ecb43c683f23f4b9c1ec1523b99fee13bf6988d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492332
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292874}
Add RBE worker labels to chromeOS rewrapper configs
Change-Id: Ia9394d316017d0b9b20854ac3821d66cb9047ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5487280
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Eric Lok <lokeric@google.com>
Auto-Submit: Eric Lok <lokeric@google.com>
Cr-Commit-Position: refs/heads/main@{#1292873}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1714078770-4f358537e11ee7f63a3107c7ecce9de0b3cc5f2a-55350bcdbb096e9cfaf2241913e5381c71911f23.profdata to chrome-win32-main-1714089593-a252e1448b962cc8a23aeec2ce1f5257342520ec-571722cf52820103038cb087a931080d413ed3b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I5d3d66dcea41c14f4aaecbbaebd94eb49caf4d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493140
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292872}
Add tracing to Legacy Dedicated Worker setup
I heard that there is a concern on migrating to PlzDedicatedWorker
may certain performance penalty. Let me add a trace for the legacy
dedicated worker code path to understand the current legacy dedicated
worker setup performance.
Bug: 333952112
Change-Id: I05c42124859578c96814107226a4a40a8c71900a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492981
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292871}
PA: Apply an AllocatorDispatch table optimization
Applies the optimization introduced by https://crrev.com/c/5385592
to allocator shims.
Bug: 40944045
Change-Id: I0b8d6aa09129459f330db645c22add3254e78609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481609
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292870}
Move ServiceWorkerContainerHost overrides to subclasses
To clarify the behavior, especially that
ServiceWorkerContainerHostForServiceWorker rejects most of
the override calls because it is non-window or doesn't have a
controller.
This CL slightly changes the logic, e.g.
before this CL `ServiceWorkerContainerHost::GetRegistration()`
checked `CanServeContainerHostMethods()` first before calling
`mojo::ReportBadMessage()`, while after this CL
ServiceWorkerContainerHostForServiceWorker::GetRegistration()`
unconditionally calls `mojo::ReportBadMessage()`.
But these changes shouldn't have impact as these calls are anyway
unreachable/invalid.
Bug: 336154571
Change-Id: I3126791fb9a368fc9e741e9df600971aabe57440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471269
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292869}
Roll clank/internal/apps from c3858aef3ee2 to 8400d244921a (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/c3858aef3ee2..8400d244921a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I25b2e5193c2e7a7701ec14e20da4682dc1ce7029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492334
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292868}
Roll devtools-internal from 053d6ed41936 to 3fb4a11b19d8 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/053d6ed41936..3fb4a11b19d8
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6809fc2603a46cc9159dcbf4fd9fa87e023ad47a..eaaf775ee972fa209764a7f444c0920bf5d818e8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I952dca02c03426a58670cabef6f9938be918ac94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492672
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292867}
Add Chrome crash observer to metric reporting manager.
Add a fatal chrome crash observer to the metric reporting manager which
sends fatal chrome crashes to a new destination: CHROME_CRASH_EVENTS.
DanglingUntriaged-notes: just updating unit test
Change-Id: Ieee2effa58edf2e5049b535aea6c5e981cd6dcad
Bug: b:332614580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478414
Commit-Queue: Josh Hilke <jrhilke@google.com>
Reviewed-by: Alberto Juarez <albertojuarez@google.com>
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292866}
bluetooth: Set up uuids during BluetothClassicDeviceMac construction
Currently, BluetoothClassDeviceMac::GetUUIDs retrieves the latest UUIDs
from the system when it is called, this might not align with how
BluetothAdapterMac uses it as it relies on the snapshot of UUIDs when
the BluetoothClassDeviceMac object is created for comparison of old and
new device objects. This CL fixes it by retrieving and storing the
device UUIDs when the device is constructed, so that the future device
change can be properly detected by comparing UUIDs of the old and new
device objects.
Bug: 326848790
Change-Id: Idb24db57f40ad3cf531ba428de4032cf9ceadf43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486476
Commit-Queue: Jack Hsieh <chengweih@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292865}
Disable DevToolsProcessPerSiteTest.PausedDebuggerFocus for flakiness
on Windows ASAN
Bug: 337141755
Change-Id: If1d6171e84507f2d9f874f77eb97c4108090d34f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493001
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Takumi Fujimoto <takumif@chromium.org>
Owners-Override: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292864}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1714078770-bbac82a411d64c09c7d393cbf1b4f709f6a3f20d-55350bcdbb096e9cfaf2241913e5381c71911f23.profdata to chrome-win64-main-1714089593-bee8e304799b61252d51466c0ee592b68baaf7b6-571722cf52820103038cb087a931080d413ed3b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I41e7277ee6f1b29cb0d60cc00aeb176c680e2cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492906
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292863}
[FedCM] Fix button flow accessibility issues
The action the screen reader takes from highest to lowest precedence:
1. Title is focused, if user sees the dialog for the first time.
2. Continue button is focused, if available. Disclosure label is
announced, if available.
3. Cancel button is focused, if on verifying sheet. "Verifying..." is
announced.
Bug: 336593607, 336318252, 336316923, 336314933, 336310279, 336309769
Change-Id: I1fbe2cc90e1368b358564a8fc817cf2d3e926570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491641
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292862}
Use base::SupportsWeakPtr<ServiceWorkerContainerHost>
To get WeakPtr for subclasses.
Bug: 336154571
Change-Id: I5fe95e0cad230036192ebda342aa1d0d359c2233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469979
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292861}
Roll ANGLE from 6cfb593174d2 to c62c0c2500b1 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/6cfb593174d2..c62c0c2500b1
2024-04-25 a.annestrand@samsung.com CL/VK: Implement initial enqueueRead/WriteBuffer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie98a4de948725eaf5b6cab03ac599b73b0248eab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492910
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292860}
snap-group: Break the group on dragging the window out
Currently, we only hide the divider when dragging the snapped window
out. The actual group removal happens in
`SnapGroup::OnPreWindowStateTypeChange()`, which will not work if
the window is re-snapped to the same snap position i.e. the snap state
remains unchanged. This may result in issues that the bounds of the two
snapped windows will have overlaps with divider stacked on top.
Demo: http://b/335311879#comment4
Fixed: b/335311879
Test: Added new test (fail w/o changes) + manually
Change-Id: Iab6120f4f121d7edb87db93c373d8fedb5428441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492296
Commit-Queue: Michele Fan <michelefan@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292859}
[URL] Make URLUtilTest pass with the non-special URL feature
URLUtilTest is one of the tests which would fail when we
enable the StandardCompliandNonSpecialSchemeURLParser feature
[^1][^2]:
The test currently uses a non-special URL, like "bogus://google.com".
When the feature is enabled, the host part in non-special URLs can be
correctly parsed. That's why the test would fail with the feature
enabled.
See the following URL parser tester for details:
https://timothygu.me/urltester/#input=bogus%3A%2F%2Fgoogle.com3A%2F%2Fnewtab
hostname:
> whatwg-url : "google.com"
> Chrome: (empty string)
This CL makes the test pass, regardless of whether the feature is
enabled or not, by making the test a parameterized test and adding
expected outputs when the feature is enabled, in preparation for
enabling the feature.
Though the main purpose of this CL is to make the test pass when the
feature is enabled, I'd like to notify a code owner that we are
changing the behavior of non-special URLs via this CL's review. Since
I'm not familiar how `MatchFilters` should work for non-special URLs,
it's recommended for a code owner or a domain expert to review and
potentially do an appropriate action in a follow-up CL, if necessary.
Depending on the severity of a potential breakage, I'd appreciate if
you could file a bug and marking it as blocking for bug 40063064 so we
don't ship the feature until all critical issues are addressed.
[^1]: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1752691/test-results
[^2]: https://docs.google.com/spreadsheets/d/1Pqw1iKXK_lxHj-kLIAeRFs-khFz-BPZDio1W7SgEVE4/
Bug: 40063064
Change-Id: Ia0f2b228f1f34a09b27a0c116ed1724c532977ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475006
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292858}
Revert "webgpu: use real proc table in swap buffer provider test"
This reverts commit 9064b996534ccc7a1f81b2dd1abeb3e4d6758fa6.
Reason for revert:
Suspected culprit of test failures: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/29687/overview
Original change's description:
> webgpu: use real proc table in swap buffer provider test
>
> Blink will soon use the WebGPU C++ API linked directly to the wire
> client functions. Thus, we can no longer rely on a custom-built
> proc table of empty functions.
>
> Bug: chromium:40195122
> Change-Id: Iaa352c13cc100fbcb6deacfea50c16a8884f112a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479009
> Commit-Queue: Austin Eng <enga@chromium.org>
> Reviewed-by: Stephen White <senorblanco@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Auto-Submit: Austin Eng <enga@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1292766}
Bug: chromium:40195122
Change-Id: I0cdd50e22574523397fce184b760e6f2ae74c156
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490843
Auto-Submit: Takumi Fujimoto <takumif@chromium.org>
Owners-Override: Takumi Fujimoto <takumif@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292857}
[PA] Fix Scheduler-loop Quarantine's metrics output
https://crrev.com/c/5377424 had a wrong format for
`kAllocatorDumpNamesForMetrics`. This CL fixed that.
Bug: 40947587
Change-Id: Id6bfa5d4c9d138d23e3796545cfe2645a807c900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472062
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Mikihito Matsuura <mikt@google.com>
Cr-Commit-Position: refs/heads/main@{#1292856}
Roll Amd64 AFDO from 126.0.6438.0_rc-r1-merged to 126.0.6440.0_rc-r2-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: I1889d5f8755f830f3df39fa2001e57d94d41aa84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492669
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292855}
Filter history clusters by after date param
Bug: 333936671
Change-Id: I082bac268cbf957db0cf3b8e51ef297c3c59d01e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479838
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292854}
arc: Remove metrics for Arc notification expand state
because we don't need them anymore.
Bug: b/41491589
Test: Manual testing - flashed dut and verified chrome://histograms
Change-Id: I98a8e17d8104b34eac196fbb551d0de56c8ac745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486999
Commit-Queue: Qijing Yao <yaoqq@google.com>
Reviewed-by: Lingyu Feng <lingyufeng@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292853}
[FedCM] Also show the newly logged in account with multi IDP
Currently, we only show the newly logged in account with the 'use other
account' button. This CL allows this to also be shown when multiple IDPs
are requested.
Bug: 325503352
Change-Id: Ic411788c1944d91a7530c1ad0d84ed5a53418a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490982
Auto-Submit: Nicolás Peña <npm@chromium.org>
Reviewed-by: Zachary Tan <tanzachary@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292852}
Jp SystemPK: Dictionary mojom api definition and proto-mojo conversions
Bug: b/336226897
Change-Id: Iff23ec9962c7aaae5e599a8e4e9eb444e513e8fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472683
Commit-Queue: jhtin <jhtin@chromium.org>
Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292851}
Introduce ServiceWorkerContainerFor{Client,ServiceWorker}
To clarify two types of ServiceWorkerContainer.
Subsequent CLs will move more logic to the subclasses.
Bug: 336154571
Change-Id: I859b5e087ebd4ee5d523288973fee323f9c062d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470160
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292850}
[infra] Fix led permission for chromium.build builders
This CL gives led permission to more groups as same as ci.shadow bucket.
This CL also removes unused mdb/foundry-x-team permission.
Change-Id: I47231bc592be0b3f07483c4fba283931e968500e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493002
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1292849}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1714067963-a2455c0b270cf3edb2508d5db771334cbfdff550-814cda3e8e3cf26961487224e48b794c4ecbbfe3.profdata to chrome-win32-main-1714078770-4f358537e11ee7f63a3107c7ecce9de0b3cc5f2a-55350bcdbb096e9cfaf2241913e5381c71911f23.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If16da7de4d8493a0472a73b9231b81d7c8ca2546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492632
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292848}
Updating trunk VERSION from 6441.0 to 6442.0
* This is an automated release commit.
* Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
Change-Id: I3139233e4ad69daf3582ceba471dfb7806dd10a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491602
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292847}
[views-ax] Add missing SetAccessibleRole
While working on CL:5445832, we noticed that the role is improperly set
for multiple views but ends up being exposed correctly to accessibility
APIs. The CL mentioned above will enforce the role to be set correctly.
There are main causes for the role not being set correctly:
1. The role is being set in GetAccessibleNodeData, but the role on the
base class is being set with SetAccessibleRole. This currently ends
up setting the role in two different AXNodeData objects, so there
are issues when we set the accessible name in one AXNodeData object
where the role is not set (the role always needs to be set before).
2. TODO
Bug: 325137417
Change-Id: Id0e2cb767bf732316b68b6b80315e0a51dde5e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485763
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292846}
Reset ChannelMixer with channel count
This CL resets the ChannelMixer in AudioDataS16Converter with the channel count in addition to the channel layout.
Bug: 336222612
Change-Id: I76f94fa09325878efcd08b6791393f3c684286fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491925
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292845}
Roll V8 from 0394417397b8 to 2522c487d9de (2 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/0394417397b8..2522c487d9de
2024-04-26 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.111
2024-04-26 rezvan@chromium.org [iterator-helpers] throw when next() is null
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: Iedfb7b628c98af78ec33095418758f0ac2835b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492666
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292844}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1714067963-3424b0ba4067a4c0803ae93ace034dbf6e4baa9c-814cda3e8e3cf26961487224e48b794c4ecbbfe3.profdata to chrome-win-arm64-main-1714089593-34b12e223db192e6babbf5ccb9872c9021a6d3ab-571722cf52820103038cb087a931080d413ed3b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I230ae3e27e3550e1127af0fafb1be3dc64913db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492329
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292843}
Roll Arm AFDO from 126.0.6438.0_rc-r1-merged to 126.0.6440.0_rc-r2-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-arm-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: If16c1a23af9cfd09c3ce74f2a970522ab396de08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492328
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292842}
Roll clank/internal/apps from e692606b12f4 to c3858aef3ee2 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/e692606b12f4..c3858aef3ee2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: If8894fe53d0980f6e6bcd817c7278c0f65156534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492908
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292841}
cr_components: Remove unnecessary use of Polymer elements
Widely shared code should not use paper- or iron- elements where
native and/or Lit-based alternatives exist.
Bug: 40943652
Change-Id: I73961d82d84b86c6a77a00147fec472efffcd88f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485912
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292840}
views: use CalculatePreferredSize(SizeBounds) in //ash/system.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
Bug: 40232718
Change-Id: Iec66c5c36ded7e6bfb193a81ef1130da31f1ea03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464990
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292839}
[ChromeVox] Rename editable_text_test.js
As part of the effort to make the ChromeVox codebase more streamlined
and easier to navigate, we are moving towards removing redundant layers
of abstraction such as ChromeVoxEditableTextBase. This change renames
the test file for clarity.
AX-Relnotes: n/a.
Bug: b:265481751
Change-Id: I70dcb58a0c8f42e53fbfb6e93a555df140382349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474546
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292838}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1714067963-95b1ce86a5104d32908db337294cd361dc8e08e2-814cda3e8e3cf26961487224e48b794c4ecbbfe3.profdata to chrome-linux-main-1714089593-c34ed62107520d21e01548b4c5adaf0372ab21d0-571722cf52820103038cb087a931080d413ed3b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I443eda95f4c075b64b449904a73d837e0710703a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492325
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292837}
webnn: add IDL and mojo definition of gelu operator
This CL also adds validation tests in WPTs and a unit test
`WebNNGraphImplTest.GeluTest`.
Bug: 40206287
Change-Id: Ia197fa637e036e73c4e7d5e832685364633c0384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470161
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292836}
Introduce object manager classes for ServiceWorkerContainerHost
To prepare for splitting `ServiceWorkerContainerHost` and
to make the class smaller,
this CL introduces two manager classes that owns and manages
`ServiceWorkerRegistrationObjectHost` and
`ServiceWorkerObjectHost` objects.
This CL doesn't change the behavior nor lifetime, because the
new manager objects corresponds 1:1 to and have the same lifetime
as `ServiceWorkerContainerHost`.
Bug: 336154571
Change-Id: I7602c628dfd746d63c4e012b0264e7004259e820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470904
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292835}