Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
bug #4488 [security] XSS injection due to unescaped table name (trigg…
…ers)

Signed-off-by: Marc Delisle <marc@infomarc.info>
  • Loading branch information
madhuracj authored and lem9 committed Jul 11, 2014
1 parent 5747537 commit 10014d4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Expand Up @@ -12,6 +12,7 @@ phpMyAdmin - ChangeLog
- bug #4440 Javascript error when renaming table
- bug #4483 'New window' link (selflink) disappears, causing Javascript error
- bug #4486 [security] XSS injection due to unescaped table comment
- bug #4488 [security] XSS injection due to unescaped table name (triggers)

4.2.5.0 (2014-06-26)
- bug #4467 shell_exec() has been disabled for security reasons
Expand Down
6 changes: 3 additions & 3 deletions libraries/rte/rte_list.lib.php
Expand Up @@ -259,9 +259,9 @@ function PMA_TRI_getRowForList($trigger, $rowclass = '')
$retval .= " </td>\n";
if (empty($table)) {
$retval .= " <td>\n";
$retval .= " <a href='db_triggers.php?{$url_query}"
. "&amp;table={$trigger['table']}'>"
. $trigger['table'] . "</a>\n";
$retval .= "<a href='db_triggers.php?{$url_query}"
. "&amp;table=" . urlencode($trigger['table']) . "'>"
. urlencode($trigger['table']) . "</a>";
$retval .= " </td>\n";
}
$retval .= " <td>\n";
Expand Down

0 comments on commit 10014d4

Please sign in to comment.