Publish DEPS for Chromium 37.0.2062.0
Navigation transitions: Added "addStyleSheetByURL" function to insert stylesheet links.
If transition-entering-stylesheet is defined in the response headers for the incoming document, they're parsed out, passed to the TransitionPageHelper in the embedder, and are applied to the page via addStyleSheetByUrl at the appropriate time in the transition.
This is the chrome side of the CL, blink side here: https://codereview.chromium.org/285623003/
Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5
BUG=370696
Review URL: https://codereview.chromium.org/309143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278856 0039d316-1c4b-4281-b951-d872f2087c98
Optimize png files in chrome/app/theme
Optimized 51/86 files in 01:05:47s
Result: 57369 => 40173 bytes (17196 bytes: 29%)
BUG=387254
TBR=msw@chromium.rog
Review URL: https://codereview.chromium.org/332343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278855 0039d316-1c4b-4281-b951-d872f2087c98
Combine the read and modify warning message for "accessibilitySettings" access.
When the extension/app requests to read and modify the accessibility settings, two messages are displayed to the user during install-time. The CL aims to combine these into one message to say "Read and modify ...".
BUG=344566
R=jww,meacer,kalman
Review URL: https://codereview.chromium.org/324273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278854 0039d316-1c4b-4281-b951-d872f2087c98
Convert ui::ScaleFactor -> float in favicon/history code
First stop to fix favicon for fractional scale factor.
I'll convert the rest of ui::ScaleFactor in 38
BUG=376367,381601
R=pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/335233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278853 0039d316-1c4b-4281-b951-d872f2087c98
Revert 278845 "Ensure all members of OriginChipInfo/OriginChipVi..."
> Ensure all members of OriginChipInfo/OriginChipView get initialized.
>
> BUG=382921
> TEST=none
> TBR=gbillock
>
> Review URL: https://codereview.chromium.org/345183005
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/341313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278851 0039d316-1c4b-4281-b951-d872f2087c98
ServiceWorker: Reject overly long scope/script URLs
IPC enforces a limit on receipt, but we should check on the sending side
and reject the (un)registration promise too.
BUG=386724
R=falken@chromium.org, michaeln@chromium.org
Review URL: https://codereview.chromium.org/342163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278850 0039d316-1c4b-4281-b951-d872f2087c98
JarJar resources when building the android_webview.
The android_webview build will require there only be
a single R class (details in bug).
This change makes the necessary changes to the build
infrastructure for this to happen but the actual swap
to building the webview this way will land as a subsequent
CL.
BUG=387155
build-only change, all trybots compile fine.
NOTRY=true
Review URL: https://codereview.chromium.org/255613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278849 0039d316-1c4b-4281-b951-d872f2087c98
Disable incognito link if parental control is on
The CL disables the incognito link on the gaia page if parental control is on. It adds a cached version for windows parental control check so that it may be accessed from IO thread. A similar CL for thread-safe android parental control check is under review at https://chrome-internal-review.googlesource.com/#/c/166265/.
BUG=383682
Review URL: https://codereview.chromium.org/336213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278848 0039d316-1c4b-4281-b951-d872f2087c98
Move ownership of the ComponentCloudPolicyService to the broker.
The ComponentCloudPolicyService needs to work with the SchemaRegistry,
so it was initially owned by the DeviceLocalAccountPolicyProvider
(which always has a valid reference to the registry). However, this
means that the ComponentCloudPolicyService can't precache any policies
until the session is started.
To enable precaching at enrollment time and at the login screen, the
ComponentCloudPolicyService has been moved to the broker instead.
This allows some code simplifications too, but requires changing the
ownership of the SchemaRegistry for device local accounts.
This CL is just moving code around; a subsequent CL will trigger
the precaching.
TBR=zelidrag@chromium.org
BUG=224596
Review URL: https://codereview.chromium.org/342233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278847 0039d316-1c4b-4281-b951-d872f2087c98
Remove ContentBrowserClient::GuestWebContentsAttached
BUG=364141
Review URL: https://codereview.chromium.org/334923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278846 0039d316-1c4b-4281-b951-d872f2087c98
Ensure all members of OriginChipInfo/OriginChipView get initialized.
BUG=382921
TEST=none
TBR=gbillock
Review URL: https://codereview.chromium.org/345183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278845 0039d316-1c4b-4281-b951-d872f2087c98
android: Fix snapshot height by including toolbar offset
The Android snapshot was found to be chopping off the bottom content. This is
due to not accounting for the height of the toolbar. This patch enlarges the
snapshot by that offset.
BUG=384551
Review URL: https://codereview.chromium.org/340603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278843 0039d316-1c4b-4281-b951-d872f2087c98
Revert of Accelerate small canvases if Ganesh is on. (https://codereview.chromium.org/326283002/)
Reason for revert:
Need to revert the blink side and this (incorrectly) adds an OVERRIDE for a cross-repository override.
Original issue's description:
> Accelerate small canvases if Ganesh is on.
>
> cc side of change.
>
> TBR=phajdan.jr@chromium.org
> BUG=382738
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276753
TBR=ajuma@chromium.org,kbr@chromium.org,phajdan.jr@chromium.org,chrishtr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=382738
Review URL: https://codereview.chromium.org/349733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278842 0039d316-1c4b-4281-b951-d872f2087c98
athena: Provide a temporary onTextInputBoxFocused.addListener implementation.
The virtual keyboard bindings will be provided by mojo soon. Until then, this is
a temporary hack to provide an implementation for the missing API. The virtual
keyboard shows up in athena with this last change.
BUG=380215
R=bshe@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/348823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278841 0039d316-1c4b-4281-b951-d872f2087c98
[Mac] Misc fixes for the new avatar bubble
In this CL:
- crbug.com/343688: when editing the profile name but not changing it, the text field would
freeze. this is because it would remain enabled, but hidden, and steal the button click
(because it used to be a first responder)
- add a separator between the "not you" and "lock" bottom option buttons, to
match the mocks. I added this as a vertical separator to the BaseBubbleController itself,
so that other classes can use it in the future.
- center the profile name correctly. Because of the pencil icon, the name would be shifted
slightly to the left
- the "change photo" overlay should be more opaque
- the bubble bottom corners were overlapped by the option buttons, and didn't appear rounded.
BUG=343688
Review URL: https://codereview.chromium.org/323143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278840 0039d316-1c4b-4281-b951-d872f2087c98
Using a mock LevelDBTransaction for corruption tests.
Was previously flushing the actual LevelDB table on disk and then corrupting.
This approach is more loosely coupled with LevelDB disk format and lays the
groundwork for future tests (and refactoring) to not rely on an actual
corrupted db.
Also reduced the number of test objects written to the db to 5.
Review URL: https://codereview.chromium.org/334303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278838 0039d316-1c4b-4281-b951-d872f2087c98
Telemetry: Set scaling governor on all cpus (on all devices)
We try to set the scaling governor for all CPU cores, but
this doesn't work SOCs that dynamically disable cores
entirely (ie. Qualcomm). Since this only happens on Qcomm,
this patch stops the 'mpdecision' process on Qualcomm, which
makes it behave like other devices.
PERF-SHERIFFS: This may improve metrics for the better given
all cores are in 'performance' mode now. It should hopefully
reduce noise, since a different number of cores might have
had 'performance' set on each run, and any code that runs on
a non-performance core will suffer from noisy timings/rates.
Example: Tough-compositor-cases std-dev went from 0.25ms to
0.04ms with this change.
BUG=383566
Review URL: https://codereview.chromium.org/338233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278837 0039d316-1c4b-4281-b951-d872f2087c98
Optimize png files in ui/resources, ash/resources
with -o2
Optimized 6/16 files in 00:03:20s
Result: 6014 => 4014 bytes (2000 bytes: 33%)
BUG=387254
TBR=msw@chromium.org
Review URL: https://codereview.chromium.org/343203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278836 0039d316-1c4b-4281-b951-d872f2087c98
Add UMA metrics for Android Chrome Google Search.
To analyze the impact of prefetching high-confidence search suggestions in Android Chrome, this CL,
- Adds a listener for counting Google searches from various search access points. No actual search query content is observed.
- Records the search count based on the prerendering settings.
(see trybot results in patchset #8).
BUG=382694
R=asvitkine@chromium.org, davidben@chromium.org, jam@chromium.org, pkasting@chromium.org, samarth@chromium.org
Review URL: https://codereview.chromium.org/342053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278835 0039d316-1c4b-4281-b951-d872f2087c98
Remove the (now-empty) sent_info field when logging QUIC ack frames.
Review URL: https://codereview.chromium.org/348553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278834 0039d316-1c4b-4281-b951-d872f2087c98
enterprise.platformKeys: Copy-on-read the 'algorithm' member of Key objects.
With this change, a Key object's algorithm member is copied on every read access. Effectively preventing it's modification as required by the WebCrypto specification.
BUG=385143
R=bartfab@chromium.org, kalman@chromium.org
Review URL: https://codereview.chromium.org/332233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278833 0039d316-1c4b-4281-b951-d872f2087c98
Move UpdateActivePermissions from ExtensionService to PermissionsUpdater
This method doesn't belong in ExtensionService, and can instead live in
PermissionsUpdater. This helps keep the permissions updating logic together.
Also update PermissionsUpdater to use a browser context instead of a profile,
where possible.
BUG=351891
Review URL: https://codereview.chromium.org/347803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278832 0039d316-1c4b-4281-b951-d872f2087c98
Define a bootstrap sandbox policy for renderer processes and enable it.
BUG=367863
R=avi@chromium.org, mark@chromium.org
Review URL: https://codereview.chromium.org/341073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278831 0039d316-1c4b-4281-b951-d872f2087c98
Disable broken Android image load test in preparation for re-landing preloader changes.
As much as I would like to keep all tests working,
it seems unreasonable to hold-back performance improvements
for all of Chromium (particularly android) to keep
this test "passing".
https://codereview.chromium.org/302063002/
BUG=387101
TBR=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/343213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278830 0039d316-1c4b-4281-b951-d872f2087c98
[Android] Battery Status API: some tweaks to the BatteryStatusManager.java.
Make sure battery status works with proper default values
on Android. Add an exception for battery present check for
Galaxy Nexus because it wrongly reports that the battery
is not present (see http://crbug.com/384348).
BUG=122593, 384348, 360068
TEST=http://jsbin.com/battery-status-diagnostics (manual)
Review URL: https://codereview.chromium.org/330333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278829 0039d316-1c4b-4281-b951-d872f2087c98
Make chrome/common compile in GN
Adds extensions common API target and extensions templates.
Adds a number of new targets: widevine, flash, sync proto, metrics proto, device serial.
Minor enhancements to protobuf and mojo templates.
TBR=jamesr
Review URL: https://codereview.chromium.org/343233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278828 0039d316-1c4b-4281-b951-d872f2087c98
DevTools: one line fix in inspect.js
BUG=
Review URL: https://codereview.chromium.org/344863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278827 0039d316-1c4b-4281-b951-d872f2087c98
Load the actual app icon in Athena.
This CL depends on: https://codereview.chromium.org/334053003/
BUG=380421
R=oshima@chromium.org, jamescook@chromium.org
TBR=sheib@chromium.org
TEST=manually
Review URL: https://codereview.chromium.org/345773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278825 0039d316-1c4b-4281-b951-d872f2087c98
Adds a field trial flag to control whether to use an alternate Instant search base page URL for prefetching search results.
BUG=382694
TEST=Run chrome with the following field trial flag and observe the Instant search base page url.
--force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /"
Review URL: https://codereview.chromium.org/330653004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278824 0039d316-1c4b-4281-b951-d872f2087c98
adjust browser_tests exclusion list for Dr.Memory bots
TBR=bruening@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/343243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278823 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278822 0039d316-1c4b-4281-b951-d872f2087c98
Update chromite dependency to df22fd72.
BUG=369659
TBR=vapier@chromium.org
Review URL: https://codereview.chromium.org/345133003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278821 0039d316-1c4b-4281-b951-d872f2087c98
Adding a SW reporter component updater.
This is a special component that only gets registered when the user reset the profile settings and has enabled UMA reporting.
Once installed (or if already installed), the component is executed and it's exit code is reported via UMA.
In case the component doesn't have time to be installed and executed before Chrome exits, a local state pref identifies that we have a pending registration or execution so that it can be continued on next Chrome startup.
BUG=377601
R=asvitkine@chromium.org, battre@chromium.org, jhawkins@chromium.org, robertshield@chromium.org, sorin@chromium.org, waffles@chromium.org
Review URL: https://codereview.chromium.org/333193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278820 0039d316-1c4b-4281-b951-d872f2087c98
[webcrypto] Remove unused ifdef now that blink has rolled.
BUG=375430
TBR=rsleevi
Review URL: https://codereview.chromium.org/345213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278818 0039d316-1c4b-4281-b951-d872f2087c98
ozone: gpu: Add plumbing for platform-specific gpu messaging (reland)
ChromeOS on bare hardware will do display configuration and cursor
movement from the GPU process. This is the conduit for the messages
needed to make this work.
This plumbing also supports other platforms with similar requirements
(e.g. wayland's port). X11 does not need any specific messaging here,
since we just call the X server from the browser.
TBR=piman@chromium.org,rjkroege@chromium.org,alexst@chromium.org,chrishtr@chromium.org
NOTRY=true
BUG=377497
Review URL: https://codereview.chromium.org/341253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278817 0039d316-1c4b-4281-b951-d872f2087c98
Clear active splice flag after an explicit Reset().
When Reset() is called outside of a config change, we need to clear
the active splice flag.
BUG=386782
TEST=new unittest
R=xhwang@chromium.org
Review URL: https://codereview.chromium.org/347813004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278816 0039d316-1c4b-4281-b951-d872f2087c98
[Win] UI fixes for the new avatar button/bubble auth errors.
Avatar bubble:
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMT2xPMnp3dEJvUms/edit?usp=sharing
- the previous code was using a temporary warning icon (while we were waiting
on UI resources), so this CL updates both the avatar button and bubble to
use the correct one
- only the warning icon was clickable for accounts with an auth error in the
avatar bubble; changed this to have the entire account name be clickable, after
chatting with Travis/Alan
- moved the icon to in front of the account name, after
conversations with UI
- fixed eliding for the account button (which wasn't missing
one of the horizontal edge margins). Screenshot:
https://drive.google.com/file/d/0B1B1Up4p2NRMczBVQ29IRlREcG8/edit?usp=sharing
Avatar button:
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMZnJsV3hlZTFjcGM/edit?usp=sharing
- fixes a bug where the avatar button text for glass windows was
displayed incorrectly when the window was maximized.
BUG=311235, 381713
Review URL: https://codereview.chromium.org/297143008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278814 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: Fix DCHECK on middle-click in window manager.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/333173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278813 0039d316-1c4b-4281-b951-d872f2087c98
Increase the child process connection timeout for browser tests.
Normally a child process kills itself if it can't connect to the browser in 15 seconds. This is to prevent a child process from staying around if the browser crashed right after launching it but before connecting to it.
When browser tests are sharded, sometimes tests run slower because of resource starvation which is why we have longer timeouts. So increase the child process connection timeout to match this.
BUG=TODO
R=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/343543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278812 0039d316-1c4b-4281-b951-d872f2087c98
Omnibox: Add Field Trial to Create UWYT When Inlining
Currently when HistoryURL provider decides to promote a match
for inline autocompletion, it will then decline to offer a what-you-typed
match even if it's valid and reasonable.
This behavior can cause problems in DisableInling mode because
this means that sometimes HistoryURL provider will not create a UWYT
match. Consequently, the default match in this mode can become a
search-what-you-typed even when the input is a valid URL. This causes
all sorts of badness and irritation.
This changelist creates a new mechanism, controlled through a field
trial parameter, that forces creation of the UWYT match if it wasn't
added due to this reason (promoted URL for inline autocompletion).
This is one approach to implement this strategy. The other approach
is in https://codereview.chromium.org/321243003/
Did some basic tests using a local field trial server with the
proper params.
TBR=pkasting
(to get this in M-37)
BUG=380357
Review URL: https://codereview.chromium.org/347963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278811 0039d316-1c4b-4281-b951-d872f2087c98
cc: Pass scaled bounds to debug border quads for drawing.
As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623
Review URL: https://codereview.chromium.org/341023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278810 0039d316-1c4b-4281-b951-d872f2087c98
Remove a hard CHECK when allocating instance ID would fail.
A CHECK here seems too intrusive to me, I've changed it
to send error response instead.
A compromised renderer should not take down the whole browser process.
BUG=364141
Test=None, internal clean up.
Review URL: https://codereview.chromium.org/345983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278809 0039d316-1c4b-4281-b951-d872f2087c98
Move ownership of ChildFrameCompositingHelper from frame to proxy.
The ChildFrameCompositingHelper is used for swapped out RenderFrames only, which I want to eliminate and replace with RenderFrameProxy. As such, it is the RFP object that should own the helper.
BUG=357747
Review URL: https://codereview.chromium.org/345823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278808 0039d316-1c4b-4281-b951-d872f2087c98
[Android] Use exceptions rather that Log.wtf on Android
AudioManagerAndroid uses Log.wtf to signal error conditions. However,
the undefined behavior of this function depending on device
configuration makes debugging difficult. Throw exceptions instead.
Review URL: https://codereview.chromium.org/340083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278807 0039d316-1c4b-4281-b951-d872f2087c98
[android_webview] Add more params to request intercepting.
This adds the following to the shouldInterceptRequest params:
- isMainFrame
- hasUserGesture
- method
- headers
This adds the following to InterceptedRequestData:
- status code
- response phrase
- headers
BUG=387086
android_webview-only CL, trybots are happy.
NOTRY=true
Review URL: https://codereview.chromium.org/284123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278806 0039d316-1c4b-4281-b951-d872f2087c98
Fixed flakiness in GetMostRecentlyAddedUserNodeForURLSkipsManagedNodes.
base::Time::Now() doesn't guarantee that successive calls don't get the
same value, and this seems to be happening on some Windows systems when
two BookmarkNodes are created one after the other in a unit test.
R=mad@chromium.org
TBR=sky@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/348893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278805 0039d316-1c4b-4281-b951-d872f2087c98
Make panels have their own shelf item in Unity.
This has the side effect of MOSTLY resolving the issue of panels always
getting focus when Chrome is activated via Alt+Tab irrespective of which
Chrome window was last activate.
- Docked "Hangouts" panels will no longer steal focus when the Chrome/browser
shelf item is activated via Alt+Tab
- Docked "Hangouts" panels will steal focus when the "Hangouts" shelf item is
activated via Alt+Tab. In particular, if there is a docked "Hangouts" panel,
the docked panel will be activated by Alt+Tab even if there is a
detached "Hangouts" panel which was more recently active.
BUG=371621
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/333593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278804 0039d316-1c4b-4281-b951-d872f2087c98
[webcrypto] Disable RSA key import for NSS versions less than 3.16.2.
Prior to NSS 3.16.2 there wasn't any validation of the RSA key parameters.
This has several consequences:
* Importing an RSA private key with another key's public modulus can be used to gain access to that key.
* importKey() can succeed for invalid RSA keys (invalid n, e, d, p, q etc).
This only affects Linux, since other platforms of Chromium bundle NSS/OpenSSL.
BUG=380424,378315
R=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/334983006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278803 0039d316-1c4b-4281-b951-d872f2087c98
views: Fix border around menu button in content settings bubble.
BUG=387012
R=msw@chromium.org
Review URL: https://codereview.chromium.org/341323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278801 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: HTML Viewer based on Blink.
Review URL: https://codereview.chromium.org/340453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278800 0039d316-1c4b-4281-b951-d872f2087c98
[DevTools] [PowerProfiler] Fix for browser crash with active timeline recording for capturing power.
The PowerProfilerService is a singleton class. It stores the PowerProfilerObserver to notify
about the power events. With the active timeline recording, the DevToolsPowerHandler registers
itself as the observer. When the tab close event occurs, the DevToolsPowerHandler is killed.
But the PowerProfilerService still contains a dangling reference to the observer thereby
causing the crash.
With this CL, DevToolsPowerHandler will remove itself from the observer to avoid the dangling
reference with the PowerProfilerService.
BUG=383725
Review URL: https://codereview.chromium.org/332623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278798 0039d316-1c4b-4281-b951-d872f2087c98
DevTools: complete 2-sided migration to attach w/ id (content)
Review URL: https://codereview.chromium.org/345113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278797 0039d316-1c4b-4281-b951-d872f2087c98
Fix malware privacy policy link
BUG=387159
NOTRY=true
Review URL: https://codereview.chromium.org/348533008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278796 0039d316-1c4b-4281-b951-d872f2087c98
Disable ServiceWorkerBlackBoxBrowserTest.Registration on Android.
This test is crashing frequently.
BUG=387045
TBR=michaeln@chromium.org
Review URL: https://codereview.chromium.org/341193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278795 0039d316-1c4b-4281-b951-d872f2087c98
Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink.
This CL enables custom color to be specified for IME composition.
Its Blink counterpart is https://codereview.chromium.org/313233002/ . Details:
- Prerequesite: the Blink change, since we assume WebCore::CompositionUnderline and
blink::WebCompositionUnderline have been updated.
- Prerequesite CL: https://codereview.chromium.org/319553002/ to allow
structures to temporarily mismatch, without triggering compiler assert.
- Adding background_color to ui::CompositionUnderline.
- To pass data from Android to Native C++, using JNI generator with callback: In C++, ImeAdapterAndroid::SetComposingText() calls Java to iterate over spans, then dispatch BackgroundColorSpan and UnderlineSpan data to C++ code and populate list of blink::WebCompositionUnderline.
We'll need to split this CL when we commit.
BUG=135900
Review URL: https://codereview.chromium.org/313053007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278794 0039d316-1c4b-4281-b951-d872f2087c98
Fixes content_browsertests with --enable-text-input-focus-manager flag enabled.
Some tests in content_browsertests are broken if --enable-text-input-focus-manager is enabled. Fix those tests.
Since not all unittests run wm::FocusController::SetFocusedWindow, it turned out that we need WMTestHelper (instead of FocusController) to clear the text input client.
BUG=290701
TEST=Run content_browsertests with --enable-text-input-focus-manager enabled.
Review URL: https://codereview.chromium.org/340413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278793 0039d316-1c4b-4281-b951-d872f2087c98
This patch makes the brand color change message available for WebContents Observer.
BUG=381447
Review URL: https://codereview.chromium.org/331793005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278792 0039d316-1c4b-4281-b951-d872f2087c98
Remove WebMediaPlayerImpl::starting_ as it's redundant.
WebMediaPlayerImpl::seeking_ essentially tracks the same state.
BUG=144683
Review URL: https://codereview.chromium.org/343053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278791 0039d316-1c4b-4281-b951-d872f2087c98
Add AllowNetworkPrediction preference name and enum.
BUG=334602
Review URL: https://codereview.chromium.org/336543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278789 0039d316-1c4b-4281-b951-d872f2087c98
When enabling new profile management programmatically, make sure to set the
experiment state correctly now that its a multi-valued option.
BUG=386680
Review URL: https://codereview.chromium.org/343023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278788 0039d316-1c4b-4281-b951-d872f2087c98
Security interstitial tweaks
Designers asked for some final tweaks to polish the interstitials. Small changes to CSS and strings.
BUG=381260
passed all of the bots at least once but cq is dead dead dead:
NOTRY=true
Review URL: https://codereview.chromium.org/344943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278787 0039d316-1c4b-4281-b951-d872f2087c98
Get iossim to compile with Xcode 6.
Xcode 6 moved the location of the frameworks that iossim depends on and
added a few new dependecies so new header files need to be generated by
the gyp target.
Note that this CL gets iossim to compile but iossim will not launch the
Xcode 6 simulator.
BUG=381213
NOTRY=true
TBR=rohitrao@chromium.org
Review URL: https://codereview.chromium.org/336773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278786 0039d316-1c4b-4281-b951-d872f2087c98
[NaCl SDK] Add pepper_36 bundle.
R=sbc@chromium.org
Review URL: https://codereview.chromium.org/348823004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278784 0039d316-1c4b-4281-b951-d872f2087c98
Use ImageSkiaSource to create ImageSkia from ImagePNGReps
gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly.
BUG=381601
TEST=covered by test.
R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278589
Review URL: https://codereview.chromium.org/340613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278783 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278782 0039d316-1c4b-4281-b951-d872f2087c98
Blink roll 176538:176561 (manual).
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176539:176561&mode=html
BUG=
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/345153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278781 0039d316-1c4b-4281-b951-d872f2087c98
gpu: Update disable_egl_khr_fence_sync for Android 4.4.4
Include this in the blacklist, since it was just released, so
assume still broken.
R=boliu@chromium.org
Review URL: https://codereview.chromium.org/343183004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278780 0039d316-1c4b-4281-b951-d872f2087c98
[PPAPI] Add browser tests for compositor API
And fix a bug found with the tests.
BindGraphics() does not work for a device which is in the same type with the current bound device.
BUG=374383
R=piman@chromium.org, raymes@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278728
Review URL: https://codereview.chromium.org/324983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278779 0039d316-1c4b-4281-b951-d872f2087c98
Android: Eliminate a bunch of unused extensions APIs.
BUG=305852
Review URL: https://codereview.chromium.org/349543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278778 0039d316-1c4b-4281-b951-d872f2087c98
Prune all safe browsing incidents when already reported.
This is an overly-big hammer that will be refined later.
BUG=383043
R=asvitkine@chromium.org, gab@chromium.org, mattm@chromium.org, noms@chromium.org
Review URL: https://codereview.chromium.org/348433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278777 0039d316-1c4b-4281-b951-d872f2087c98
Expand the JsonPrefStore's interface to allow for an alternate filename to be specified.
The alternate filename is intended to be the old name of the pref file being read, JsonPrefStore handles the migration if required. JsonPrefStore's FileThreadDeserializer is the best place to do this as it's the only code in the prefs stack running on a thread allowed to do IO (another solution would be to let JsonPrefStore take a PreReadOnFileThreadCallback to abstract the required work away, but the direct approach seemed easier here without breaking encapsulation).
BUG=372547
Review URL: https://codereview.chromium.org/347793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278776 0039d316-1c4b-4281-b951-d872f2087c98
[DevTools] Take passed scale/offset into account in ScreenMetricsEmulator.
BUG=327641
Review URL: https://codereview.chromium.org/348583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278775 0039d316-1c4b-4281-b951-d872f2087c98
Cast: Avoid retransmit if we sent the same packet recently (less than RTT)
When transmitting 4Mbit over the "bad" udp_proxy profile, this reduces the
amount of data sent from 12Mbit/s to 7Mbit/s, and seems to make it able to
actually send more frames across the wire and recover faster.
Review URL: https://codereview.chromium.org/343523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278774 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278773 0039d316-1c4b-4281-b951-d872f2087c98
Roll libvpx 269083:278497
See https://codereview.chromium.org/344903003/
for the actual changes.
BUG=386801
R=tomfinegan@chromium.org
Review URL: https://codereview.chromium.org/348683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278772 0039d316-1c4b-4281-b951-d872f2087c98
Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs.
The main usage of the keyCode attribute is to supports sending correct
soft key events. On the on-screen keyboard, each key should have the
keyCode attached, e.g. the key on the right side of TAB key, in US
keyboard layout, it has key:'q',code:'KeyQ',keyCode:0x51; while in FR
keyboard layout, it has key:'a',code:'KeyQ',keyCode:0x41.
Another example is for UK extended keyboard layout, the '#' key (at the
backslash key location), it has key:'#',code:'BackSlash',keyCode:0xDE;
while for US keyboard, it has key:'\\',code:'BackSlash',keyCode:0xDC.
A real case that this cl will fix is on FR on-screen keyboard, pressing
Ctrl+A will trigger Ctrl+Q shortcut.
BUG=355261
TEST=None
Review URL: https://codereview.chromium.org/346513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278771 0039d316-1c4b-4281-b951-d872f2087c98
Log errors from libusb.
Convert numeric error code from libusb into human readable strings and
log them. Some of these errors should, in addition, be passed up to the
running script.
BUG=
Review URL: https://codereview.chromium.org/344793009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278769 0039d316-1c4b-4281-b951-d872f2087c98
Download archives contain git or svn revisions in the filename.
Due to recent Git mirgration on bots, builds are archived using Git hash in filename
instead of SVN revision. Bisects should check for builds either with Git hash or SVN
revisions and download.
Also this CL allows bisect to continue when a revision under test fails to build
(except good or bad revisions).
BUG=385734,385356,380304
NOTRY=true
Review URL: https://codereview.chromium.org/344123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278767 0039d316-1c4b-4281-b951-d872f2087c98
New ZipReader::ExtractCurrentEntryToString API.
New API which extract a zip entry into a memory buffer.
BUG=359428
Review URL: https://codereview.chromium.org/292443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278766 0039d316-1c4b-4281-b951-d872f2087c98
Revert 278728 "[PPAPI] Add browser tests for compositor API"
> [PPAPI] Add browser tests for compositor API
>
> And fix a bug found with the tests.
> BindGraphics() does not work for a device which is in the same type with the current bound device.
>
> BUG=374383
> R=piman@chromium.org, raymes@chromium.org
>
> Review URL: https://codereview.chromium.org/324983005
TBR=penghuang@chromium.org
Review URL: https://codereview.chromium.org/342323006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278765 0039d316-1c4b-4281-b951-d872f2087c98
Update flag description to make clear why it's needed.
BUG=379076
NOTRY=true
Review URL: https://codereview.chromium.org/343173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278763 0039d316-1c4b-4281-b951-d872f2087c98
Fix chrome.identity.onSignInChanged regression for sign-outs
This change fixes a regression from r270325, allowing sign-out events
to fire when the --enable-new-profile-management flag is absent, which
is the default.
The previous change added a check to filter out events related to
non-primary accounts, but the primary account ID is not available
during sign-out. Removing the filter fixes the regression.
BUG=376421
Review URL: https://codereview.chromium.org/346913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278762 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278760 0039d316-1c4b-4281-b951-d872f2087c98
Add webapp hashes to whitelist for window shape API.
BUG=386324
Review URL: https://codereview.chromium.org/340883005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278759 0039d316-1c4b-4281-b951-d872f2087c98
Skia roll 9efd66b:6b8f1ba
https://skia.googlesource.com/skia/+log/9efd66b8451f25465abd1027e09a3bcfa7b9c554..6b8f1ba1ef71a762e961c3a8bc8b344c88990a04
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=reed@google.com
BUG=
Review URL: https://codereview.chromium.org/348043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278757 0039d316-1c4b-4281-b951-d872f2087c98
Use the same set of switches for service process autorun and for launching process from browser.
BUG=386897
TBR=rogerta
NOTRY=true
Review URL: https://codereview.chromium.org/347953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278755 0039d316-1c4b-4281-b951-d872f2087c98
visibility bug fix for 246844 on Linux machines
BUG=246844
It fixes the the bug on Linux machines by propagating the window minimization
information to the content window after receiving X event from the platform, so
the render side can update its visibility properly.
Review URL: https://codereview.chromium.org/340783004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278754 0039d316-1c4b-4281-b951-d872f2087c98
ozone: Add README files for subdirectories
Not everything is in the right place yet, but this is the general idea.
NOTRY=true
Review URL: https://codereview.chromium.org/342983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278753 0039d316-1c4b-4281-b951-d872f2087c98
Make some l10n values on Options independent from ENABLE_FULL_PRINTING.
"showSetDefault" and "allowAdvancedSettings" should not be set
via RegisterCloudPrintValues call since they are not related
to Google Cloud Print.
R=bcwhite@chromium.org
Review URL: https://codereview.chromium.org/263803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278752 0039d316-1c4b-4281-b951-d872f2087c98
Move GenerateSearchURL() and GenerateKeyword() from TemplateURLService to TemplateURL
TemplateURL should not depend on TemplateURLService.
BUG=386365
TEST=unit_tests
R=pkasting@chromium.org
TBR=profile_resetter, renderer_context_menu}, sky@chromium.org for chrome/browser/{importer
Review URL: https://codereview.chromium.org/343823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278751 0039d316-1c4b-4281-b951-d872f2087c98
Fixed build on Windows with Cygwin (get_syzygy_binaries script).
1. Allow get_syzygy_binaries to run in cygwin.
2. On cygwin, get_syzygy_binaries makes all of the binaries it unpacks
executable (to avoid "permission denied" errors during compilation).
BUG=386911
Review URL: https://codereview.chromium.org/341183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278748 0039d316-1c4b-4281-b951-d872f2087c98
TSAN: Excluding more tests that are timing out.
BUG=385222
TBR=thakis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/344193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278747 0039d316-1c4b-4281-b951-d872f2087c98
[AiS] Add disable flag to about_flags.
BUG=386638
Review URL: https://codereview.chromium.org/342713007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278746 0039d316-1c4b-4281-b951-d872f2087c98
Move images from drawable to drawable-mdpi.
The benefits: Android lint can find resources that don't exist in all
resolutions, it's clearer what resolution these images are, and the drawable
folder is neater as well.
The build output after this change is identical, thanks to recent build changes
(https://codereview.chromium.org/321463002) as well as the method
MoveImagesToNonMdpiFolders() in package_resources.py.
BUG=289843
R=dtrainor@chromium.org, tedchoc@chromium.org
Review URL: https://codereview.chromium.org/340913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278745 0039d316-1c4b-4281-b951-d872f2087c98
Remove Skia suppressions.
Blink rebaselines have landed.
BUG=383435
TBR=reed@google.com,humper@google.com
Review URL: https://codereview.chromium.org/345933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278744 0039d316-1c4b-4281-b951-d872f2087c98
Update perf_expectations for linux chrome-data/data
BUG=387110
TBR=yzshen@chromium.org
Review URL: https://codereview.chromium.org/348533006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278742 0039d316-1c4b-4281-b951-d872f2087c98
Simulate variation seeds using installed version string.
Exposes getting the installed version from UpgradeDetector and
uses it from VariationService when simulating new Finch seeds,
so that the simulation more accurately reflects what will happen
on a restart when that seed will be applied.
BUG=315807
Review URL: https://codereview.chromium.org/333313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278740 0039d316-1c4b-4281-b951-d872f2087c98
Show proper message when host list is empty.
host-list-empty was placed inside of daemon-control, so it was not
visible when daemon-control div was not visible.
BUG=384053
R=jamiewalch@chromium.org, kelvinp@chromium.org
Review URL: https://codereview.chromium.org/345773005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278739 0039d316-1c4b-4281-b951-d872f2087c98
Password internals page: notify renderer about logging state on client construction
Currently, ChromePasswordManagerClient informs the PasswordAutofillAgent almost every time about changed availability of the internals page. The only exception is when the client is created. As a result, new tabs opened after a chrome://password-manager-internals tab will only cause browser-side logs.
When the client is created, the agent on the renderer side may not exist yet. So it does not help to send messages to the agent during constructing the client.
Instead, this CL introduces a new "ping" IPC message from the renderer to the browser, which the agent uses to explicitly request logging state update from the client at the time the agent is constructed.
BUG=384269
Review URL: https://codereview.chromium.org/336763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278738 0039d316-1c4b-4281-b951-d872f2087c98