Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
cros_healthd: Sync mojom for LedLitUpRoutineReplier removal
Sync CL:5397977.
Bug: b:309781398
Test: CQ
Change-Id: Ibdf7210f9f448116abcc424932ff958325119204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5398238
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Kerker Yang <kerker@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280123}
[Uno-D][ProfileMenu] Remove customize profile from Guest mode
This will be tested in a followup CL where the
kExplicitBrowserSigninUIOnDesktop will be enabled by default on all
browser tests since there should be no effect with and without the
flag.
Bug: b/319397639
Change-Id: Id06647e93638888b24a77d485d9825bebc005931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401768
Auto-Submit: Ryan Sultanem <rsult@google.com>
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280122}
[CBD] Clean unused kPreferencesMigratedToBasic pref
Bug: 331342247
Change-Id: I4421328f105da8965930541404fc17de0e47a71e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402871
Auto-Submit: Filipa Senra <fsenra@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280121}
[ios] Remove unused import from tab_group.proto
Bug: none
Change-Id: I3f3e7a45535dad1d610778763c708dfc78b6f6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402148
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280120}
Add LCPPMultipleKey config
Bug: 328487899
Change-Id: Ie69b5c13563cc73c2cc491349f4ef447d9715398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394854
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280119}
Roll androidx from dGbVYvAHJBTUP_3Sm... to L_FsHdBZ8ZhhbLwBY...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: Ide460d75bb816f4978c3e2503c111daf31047bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406599
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280118}
cros: metrics: network: Drop a few shill metrics
TimeOnline is broken since M104. TimeToDrop has been expired for a long
time and seems that no one is using that.
The platform code for emitting these metrics has been removed in
https://crrev.com/c/5401295 .
Bug: b/331562373
Test: None
Change-Id: I2aa13e9769d9713909b1d7539404c03063905174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404455
Reviewed-by: Matthew Wang <matthewmwang@chromium.org>
Commit-Queue: Jie Jiang <jiejiang@chromium.org>
Reviewed-by: Hugo Benichi <hugobenichi@google.com>
Cr-Commit-Position: refs/heads/main@{#1280117}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1711691764-7f932f0c446a8344b42ef6ae74995b37c43d668d-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata to chrome-mac-arm-main-1711698346-e8acb678359ea146b6d9b44cdc23f025e077a23d-4a605cc2559bfcd44c4859447e2b48101531c87f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6dd693d6e8025249a9772f594f4e02fdd391078b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5407053
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280116}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1711626851-25217029020dde6373cfef3c08c961517a5f8c06-5d93e80eeb4e867198539369fa6e24d504b8ff83.profdata to chrome-mac-main-1711691764-d9683b67b3a7e92bda753fc0ba621b789852a582-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie1322af94ba251be6d24aeb6f78bb181562f80b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406210
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280115}
Roll ios_internal from 0b679a60963c to 55990afd5d80
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/0b679a60963c..55990afd5d80
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,ginnyhuang@google.com,hiramahmood@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I6cef7266251957f4c04894d66501d77a2659cd81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5407052
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280114}
Roll Amd64 AFDO from 125.0.6379.0_rc-r2-merged to 125.0.6384.0_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: Ic5be5c88c1efc1b54aa8306726650cc1a074e760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406680
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280113}
Roll WebRTC from 02af84064c5f to cc91e075ea25 (1 revision)
https://webrtc.googlesource.com/src.git/+log/02af84064c5f..cc91e075ea25
2024-03-29 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2024-03-29T04:04:06).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I644527c64cf7e90d1b8158627e184a128fd36017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5407034
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280112}
[bfcache] Report null when iframes' atrributes are null
In HTMLIframeElement::ConvertToReportValue(), we used to convert null to
an empty string. This function builds a value based on iframes'
attributes when they change. They are sent to the browser side.
The only web-exposed usage of this is NotRestoredReasons API.
NotRestoredReasons used to report an empty string for non-set iframes'
attributes.
With this fix, NRR API starts reporting null for non-set attributes.
No tests broke with this change, except for the NotRestoredReasons tests
that expected the wrong thing (an empty string instead of null).
Bug: 331883460
Change-Id: Ic15d75562e7f473c34b8c85aea6900ff8f51d961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394900
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280111}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1711684005-46dabddd5b50a7e59bfb138a2778882315fb363b-1c13dda8aff4fc0dfb70420b869bf3e3c9310bcd.profdata to chrome-android64-main-1711691764-98a03c2a06f8dca69cf38b3097fc1d4909e5f1f6-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I7d064a7472dcd4590503e64137e53248aab2ba4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406211
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280110}
[//gpu] ClientSI: Separate out construction with/without SIIHolder
The only construction path in which ClientSharedImage is not supplied an
SIIHolder is via ImportUnowned(). This CL changes that path to go
through a new constructor that doesn't have an SIIHolder param and
changes the other constructors to CHECK() that an SIIHolder was passed.
This paves the road for accessing the SIIHolder in SetTextureTarget()
invoked from those constructors to obtain the MacOS-specific texture
target.
Bug: 41494843
Change-Id: I3c2c48c7230d3bbbc2bdf8991d4fd611676f52b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402876
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280109}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1711670326-ff2c03db92ad48cbdfb742a8bb9341bce73a6ef7-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata to chrome-linux-main-1711691764-dd8dbc6ab138c8bbe2f503493553e5bf4ff991f4-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I30bafda48d850f0ab6985f0e2c59523a25f8377a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406250
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280108}
Reland "Roll clang+rust llvmorg-19-init-2941-ga0b3dbaf-22 : llvmorg-19-init-6501-g5b544b51-1 / 7168c13579a550f2c47f7eea22f5e226a436cd00-2 : b13a71a2e77f4625d1a2b8a5b9488414686ebca9-1"
This reverts commit 13dc9eae05d2638c112ff003c9b200824c990542.
Reason for revert: retry win-arm64 bot
Original change's description:
> Revert "Roll clang+rust llvmorg-19-init-2941-ga0b3dbaf-22 : llvmorg-19-init-6501-g5b544b51-1 / 7168c13579a550f2c47f7eea22f5e226a436cd00-2 : b13a71a2e77f4625d1a2b8a5b9488414686ebca9-1"
>
> This reverts commit 1e35a7e3cf2c1dcb8be17715db59ed8fbaa85ac2.
>
> Reason for revert: may cause tree close: https://ci.chromium.org/ui/p/chromium/builders/ci/win-arm64-rel/729/overview.
>
> Original change's description:
> > Roll clang+rust llvmorg-19-init-2941-ga0b3dbaf-22 : llvmorg-19-init-6501-g5b544b51-1 / 7168c13579a550f2c47f7eea22f5e226a436cd00-2 : b13a71a2e77f4625d1a2b8a5b9488414686ebca9-1
> >
> > Additionally, regenerate the abseil def files.
> >
> > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/a0b3dbaf..5b544b51
> >
> > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/7168c13579a5..b13a71a2e77f
> >
> > Ran: ./tools/clang/scripts/upload_revision.py 5b544b511c7133fcb26a5c563b746a4baefb38d6
> >
> > Bug: 327446425
> > Disable-Rts: True
> > Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
> > Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
> > Cq-Include-Trybots: chromium/try:lacros-arm64-generic-rel
> > Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
> > Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
> > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
> > Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
> > Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng
> > Cq-Include-Trybots: chromium/try:win-asan,android-official
> > Cq-Include-Trybots: chromium/try:fuchsia-arm64-cast-receiver-rel
> > Cq-Include-Trybots: chromium/try:mac-official,linux-official
> > Cq-Include-Trybots: chromium/try:win-official,win32-official
> > Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86
> > Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-dbg
> > Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-rel
> > Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-dbg
> > Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-rel
> > Cq-Include-Trybots: chromium/try:android-cronet-riscv64-dbg
> > Cq-Include-Trybots: chromium/try:android-cronet-riscv64-rel
> > Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
> > Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome
> > Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo
> > Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
> > Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
> > Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
> > Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
> > Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
> > Cq-Include-Trybots: chromium/try:mac-rust-x64-dbg
> > Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
> > Cq-Include-Trybots: chromium/try:win-rust-x64-rel
> > Change-Id: Ifbb7a18cd24be9c620b958c154b13a2ad1b85b48
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5399878
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1279833}
>
> Bug: 327446425
> Change-Id: I62f969a45e5aa247ad608591ef8abca33e663445
> Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
> Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
> Cq-Include-Trybots: chromium/try:lacros-arm64-generic-rel
> Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
> Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
> Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
> Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
> Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng
> Cq-Include-Trybots: chromium/try:win-asan,android-official
> Cq-Include-Trybots: chromium/try:fuchsia-arm64-cast-receiver-rel
> Cq-Include-Trybots: chromium/try:mac-official,linux-official
> Cq-Include-Trybots: chromium/try:win-official,win32-official
> Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86
> Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-dbg
> Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-rel
> Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-dbg
> Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-rel
> Cq-Include-Trybots: chromium/try:android-cronet-riscv64-dbg
> Cq-Include-Trybots: chromium/try:android-cronet-riscv64-rel
> Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
> Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome
> Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo
> Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
> Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
> Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
> Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
> Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
> Cq-Include-Trybots: chromium/try:mac-rust-x64-dbg
> Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
> Cq-Include-Trybots: chromium/try:win-rust-x64-rel
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403140
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Xi Han <hanxi@chromium.org>
> Owners-Override: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1279912}
Bug: 327446425
Change-Id: Ie6784b18dffe5aa90636daaddc6a05bd1c37c8e5
Cq-Include-Trybots: chromium/try:win-arm64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405904
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Alan Zhao <ayzhao@google.com>
Cr-Commit-Position: refs/heads/main@{#1280107}
Revert "Fix Check for AAC on Windows N"
This reverts commit 705e9082e97f3ad583223a17a09a0fb865238851.
Reason for revert:
MediaRecorderHandlerTest related tests, including the newly introduced `MediaRecorderHandlerIsSupportedTypeTestForMp4.CanSupportAacCodecForWinNSku`, are failing.
First failing build https://ci.chromium.org/ui/p/chromium/builders/ci/win11-arm64-rel-tests/699/overview
Original change's description:
> Fix Check for AAC on Windows N
>
> In the context of Windows N SKU, the isTypeSupported function
> does not include support for AAC (Advanced Audio Coding) encoding.
> In standard Windows operating systems, AAC encoding relies on the
> Media Foundation library. However, this library is not installed
> by default in Windows N SKU, resulting in the lack of AAC encoding support.
>
> The straightforward solution is to check whether the system is
> running Windows N SKU and return false for AAC support.
>
> An alternative approach involves examining the presence of
> the Media Foundation binaries (such as mf.dll). Unfortunately,
> this file existence check cannot be performed directly in the
> renderer process. The GPU process already handles this check,
> but the isTypeSupported API operates synchronously and cannot
> utilize a Mojo-based solution.
>
> It’s worth noting that Windows N SKU is optional for European
> countries and Korea, although it is not widely used. Therefore,
> a simple check based on the product type could be a more effective solution.
>
> Bug: 329698355
> Change-Id: I00e946895d18377e87c6b8c57539184722c086f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5379757
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Sunggook Chue <sunggch@microsoft.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Markus Handell <handellm@google.com>
> Cr-Commit-Position: refs/heads/main@{#1280027}
Bug: 329698355
Change-Id: I4a39781f74c4e4784fa9f3b55826823fda274cb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404312
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Robert Lin <robertlin@google.com>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280106}
Roll vulkan-deps from f7bacc91292a to cb27f57dc052 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f7bacc91292a..cb27f57dc052
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5d79677e78..899fa3acb3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC angle-team@google.com,dneto@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,solti@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: dneto@google.com,radial-bots+chrome-roll@google.com,solti@google.com
Change-Id: I846590017df2e4c1cd2123e96bccb383e2d7b0b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405534
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280105}
Roll devtools-internal from 00c560a7dc56 to c2a4abe676c5 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/00c560a7dc56..c2a4abe676c5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I735fc666954c5d91a04d1a3c127a9311a0d4e882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406788
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280104}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1711670326-98736e550a98fcc7ef37f1fa502b7018aab4241f-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata to chrome-win-arm64-main-1711691764-133d84f67dd2c7a61800b5a8e7859f5908fd4131-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I666810257332eeffac981e854f9d873a412140e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406679
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280103}
Roll Catapult from 6abf8f51e0ae to d4b67cd8aae9 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/6abf8f51e0ae..d4b67cd8aae9
2024-03-29 jeffyoon@google.com Update OWNERS to Berf members
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC chrome-speed-operations@google.com,dberris@chromium.org,jbudorick@chromium.org,johnchen@chromium.org,sullivan@chromium.org,viditchitkara@google.com,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: viditchitkara@google.com
Change-Id: Icdff019c638cd67cd3a1aaaa337dab62a4572f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404225
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280102}
cros_healthd: Remove [Stable] for LedLitUpRoutineReplier in mojom
Remove the [Stable] attributes in order to remove the `replier` field in
`LedLitUpRoutineArgument` in the next commit.
Bug: b:309781398
Test: CQ
Change-Id: Ia01848c1dc16683f1ac2841953bbfbec354ac1ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5398237
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kerker Yang <kerker@chromium.org>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1280101}
Roll V8 from cb4f9fffdcab to 95d880e54419 (2 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/cb4f9fffdcab..95d880e54419
2024-03-29 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.5.129
2024-03-29 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 DEPS (trusted)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I5841d8c79ae7a44ee95a6958e1ff5d98c9a0d56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406694
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280100}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1711670326-bebaacd3f5509b9e9cab3099f8663f148bafeb67-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata to chrome-android32-main-1711691764-333784b80010210556df70d31d689a071ccdfceb-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I37f87e569daf2f4197f1ec49e47aaafa8300c528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406814
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280099}
Roll Skia from f5bffebda8e0 to b2a01ae03cdf (3 revisions)
https://skia.googlesource.com/skia.git/+log/f5bffebda8e0..b2a01ae03cdf
2024-03-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d9a2f3150285 to 33ace26e29f4 (9 revisions)
2024-03-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8220ee868483 to 2126889e45aa (11 revisions)
2024-03-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f0178b3c40e7 to ff61926fcedb (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jamesgk@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jamesgk@google.com
Change-Id: I3c7107271d9dc7b550e267c2d01746b4fcf18121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406715
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280098}
PA: Compute bucket order constants
This CL introduces no behavioral change. It changes the hardcoded
C-style arrays of bucket
* order index shifts and
* order sub-index masks
into templated, computed `std::array`s. As a side effect, the
preprocessor scaffolding is stricken.
Change-Id: I38bf798f0619cf6c536846ae636220e4ad0d102b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5400858
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/main@{#1280097}
[lacros skew tests] Refresh skew tests for M125
This CL updates the ash version ['125.0.6386.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: Ib60cc439ab616f9b1e712ed250a224d00a1a1398
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405535
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280096}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1711670326-7ef52985c3b37adb095eb7e548a8b335f7ce95ee-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata to chrome-win32-main-1711681130-0e0219d9a54ce0ed3573eafcdbf79d239142fd3a-0c35426464f0687a45e20e07ba820d845d3b155b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I48ac937b505e13faf897b46129001078279e9c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406209
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280095}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1711684005-18fb4ba3cf8cf34392edb57ba479617956bd52ab-1c13dda8aff4fc0dfb70420b869bf3e3c9310bcd.profdata to chrome-mac-arm-main-1711691764-7f932f0c446a8344b42ef6ae74995b37c43d668d-bbbab271f75a45af42da5685ff7df25e0bb200b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6b068412fc07ba0280bdae2ec8e1c7df7b0521f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406678
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280094}
css-text: Fix an issue on justification with a bidi isolate control
Do not reset `is_after_expansion` state by a default ignorable code
point, which includes bidi controls.
Bug: 331680200
Change-Id: I2c79ec467052861e9048b0b7575e8f29dc0570b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401304
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280093}
cros_healthd: Sync mojom for network bandwidth routine
Sync CL:5333378.
Bug: b:320631510
Test: CQ
Change-Id: I342049342926df631f2e77dfee3ae1d01dda21c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404311
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Reviewed-by: Byron Lee <byronlee@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280092}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1711670326-d76c5fd3f47906b637f24f276563f5c1ce63ee1b-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata to chrome-win64-main-1711681130-9b9f448e0ceda029cff25f9a5a11259e9e32b54b-0c35426464f0687a45e20e07ba820d845d3b155b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I1dd4b0808fa7ce9be747443fef8322a9d5f15028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406598
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280091}
[RemoveLegacy] Remove dead code in blink::Character
This CL removes:
* LegacyTreatAsZeroWidthSpaceInComplexScript(), and
* NormalizeSpaces()
This CL has no behavior changes.
Bug: 40056555
Change-Id: I1ceee905bc6547b1e8fcb3dc493fff7ab7a05034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401541
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280090}
Roll Catapult from 406a66d687fc to 6abf8f51e0ae (1 revision)
https://chromium.googlesource.com/catapult.git/+log/406a66d687fc..6abf8f51e0ae
2024-03-29 jeffyoon@google.com Deploy perf-issue-service to 406a66d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC chrome-speed-operations@google.com,dberris@chromium.org,jbudorick@chromium.org,johnchen@chromium.org,sullivan@chromium.org,viditchitkara@google.com,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:331730780
Tbr: viditchitkara@google.com
Change-Id: I475cacae3b20b0ea76bf8f8423923924658e9cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406677
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280089}
[Extensions] Remove TTS voice parsing logic
Remove installation warning about ignored TTS voice gender attribute.
Bug: 324534603
Change-Id: I88168ece3793fb70e32b515cc408ba4e44498388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5331883
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anton Bershanskyi <bershanskyi@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1280088}
Roll V8 from 8d7006d6947c to cb4f9fffdcab (2 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/8d7006d6947c..cb4f9fffdcab
2024-03-29 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.5.128
2024-03-29 ayzhao@google.com Add .att_syntax for inline asm for v8::internal::trap_handler::ProbeMemory
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I51be369e9a6a0103c7fa94d8c29e798466953993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406248
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280087}
Reland "build: remove references to use_goma"
This reverts commit bfa598b72f1daa3a468bb76390216e32607ca43a.
Reason for revert:
Removed chromeos related changes.
Original change's description:
> Revert "build: remove references to use_goma"
>
> This reverts commit 296be8434a7fe1af9cf8a55d6324217b3c7ef7e1.
>
> Reason for revert: http://b/331553993
>
> Original change's description:
> > build: remove references to use_goma
> >
> > Bug: 41489832
> > Change-Id: I19155fd7233930a15f9e9a573ae86c5c88d7d8a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385591
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1278096}
>
> Bug: 41489832, 331553993
> Change-Id: I0f1bbaecf282e111541b878d527680add19e8077
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5399667
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1278851}
Bug: 41489832, 331553993
Change-Id: I3ea16bbfb96b8614663dea84550c13601dac0154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403632
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280086}
Roll devtools-internal from cd9ce4e832d0 to 00c560a7dc56 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/cd9ce4e832d0..00c560a7dc56
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/76fb67878ed6c594d1e9a1c118ee1439335bff6f..080a0de20617e0fa3983c29f21e53f6ed6c9fcb9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I6f0ff82fe4e7ae29575c25611ebb16935e6fb316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405391
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280085}
bindings: Change a perf owner from yukishiino to japhet
Change-Id: Ia112654073115fc8b7b00cd80585625fde355706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404432
Auto-Submit: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280084}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1711677504-8822956cfe56cc5956f501ca20049c6d1d5c0ca7-14006fc90c358cbeae0fd3a3776f0be76388baec.profdata to chrome-android64-main-1711684005-46dabddd5b50a7e59bfb138a2778882315fb363b-1c13dda8aff4fc0dfb70420b869bf3e3c9310bcd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I3bb15d75aaf2ebf7a97b601bf9e990ae50bb3676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406456
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280083}
Roll clank/internal/apps from dd2ed4a1be32 to 4bf4c2c601a6 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/dd2ed4a1be32..4bf4c2c601a6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I910ccdcc672799680b94880472a0a6ffab955a62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406249
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280082}
Migrate static_casts to WindowTreeHostPlatform::GetHostForWindow
Bug: None
Test: CQ
Change-Id: Ib64e6c4b196b8ba54e01eda5e2b9ddad77a04aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385589
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280081}
Revert "Add screenshot verbs to kombucha test - PTB"
This reverts commit 4c917fe417fcb2d74e1d212e52a1929b48a6edb9.
Reason for revert:
PrivacySandboxSettingsTopicsInteractiveTest.StartWithOneBlockedTopic,
PrivacySandboxSettingsTopicsInteractiveTest.ValidateScreenshotDefaultManageTopicsPage and
PrivacySandboxSettingsTopicsInteractiveTest.ValidateScreenshotsWithFirstTopicBlockedWithJS are failing, and the last two are added in this CL.
https://ci.chromium.org/ui/p/chromium/builders/ci/win11-arm64-rel-tests/b8752196935881488337/overview
Original change's description:
> Add screenshot verbs to kombucha test - PTB
>
> Bug: 326286372
> Change-Id: I54e8657609be35d0523c87c5eb5cc383c1d7cf2c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5397397
> Commit-Queue: Jacob Stanley <jacobstanley@google.com>
> Reviewed-by: Abe Boujane <boujane@google.com>
> Cr-Commit-Position: refs/heads/main@{#1279685}
Bug: 326286372
Change-Id: Id0cb1800670d0b3b995a9501405e0cb23bb939d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401501
Owners-Override: Robert Lin <robertlin@google.com>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280080}
Roll V8 from 30f500edd50b to 8d7006d6947c (5 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/30f500edd50b..8d7006d6947c
2024-03-28 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.5.127
2024-03-28 adamk@chromium.org Remove APIs that have been deprecated for more than a year
2024-03-28 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 DEPS (trusted)
2024-03-28 thibaudm@chromium.org [wasm] Set missing turboshaft wrapper node origins
2024-03-28 syg@chromium.org [api] Deprecate v8::BackingStore::Reallocate
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I00ecb3b2a3c87fe2c683f99c8c02cca625e2a765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405849
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280079}
Roll Fuchsia SDK from 19.20240328.1.1 to 19.20240328.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com,cr-fuchsia@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast-receiver-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Disable-Retries: true
Change-Id: Ib746ec244ad6a61f0e879cbe606bd9ef2ceb24db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406363
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280078}
[Extensions cleanup] Use existent extension and web contents variables
Use existent extension and web contents variables instead of
retrieving them again.
Bug: n/a
Change-Id: I65015ac1f3ec0ead59ce8564dcbc4dac9fdf70f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406493
Auto-Submit: Emilia Paz <emiliapaz@chromium.org>
Reviewed-by: Justin Lulejian <jlulejian@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280077}
Roll optimization-guide from 9e938bc0da51 to c921068854f5
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/9e938bc0da51..c921068854f5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Iae7a17c7a19ec2d1acf47b9118a58574f8445652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405390
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280076}
Reland "Remove kDCompVisualTreeOptimization feature flag"
This is a reland of commit 5b54e581ad2ae4324ff07adda3ce06e4a2ecca48
Reland adds back DCHECK_IS_ON #if's for unit tests that call
methods which are only available in DEBUG builds.
Original change's description:
> Remove kDCompVisualTreeOptimization feature flag
>
> Optimized tree building has been enabled for Chromium releases.
> Time to say goodbye to the non-optimized version.
>
> Bug: 41490668
> Change-Id: Ifc64876004a9e2870a02bff310fd238bd4d3479b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5399690
> Reviewed-by: Michael Tang <tangm@microsoft.com>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1279388}
Bug: 41490668
Change-Id: Ic8f1d496c6ab64c3bf7837c622a2e5f5148794d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405860
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1280075}
Revert "[Extensions] Confirm that worker renderer start is always second."
This reverts commit 2e4126cd62c47b13f1f3426d072fa189ba811056.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5736178307301376
Sample build with failed test: https://ci.chromium.org/b/8752178974186451617
Affected test(s):
[ninja://chromeos:chrome_all_tast_tests/ui.ChromeCrashLoggedIn.browser_crashpad_mock_consent](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchromeos:chrome_all_tast_tests%2Fui.ChromeCrashLoggedIn.browser_crashpad_mock_consent?q=VHash%3Af4f218de31c62e5b)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5736178307301376&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5405554&type=BUG
Original change's description:
> [Extensions] Confirm that worker renderer start is always second.
>
> Inserts a dump without crash to confirm an assumption that
> DidStartServiceWorkerContext() now always arrives after
> DidStartWorkerForScope() in practice.
>
> Bug: 40276609
> Change-Id: I40ee7ede20f678a8a5ec775cc9bb92e3e118d10c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405554
> Commit-Queue: David Bertoni <dbertoni@chromium.org>
> Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
> Reviewed-by: David Bertoni <dbertoni@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1279927}
>
Bug: 40276609
Change-Id: I7ffc134ca08bee272f306068686d92082a66e885
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405911
Reviewed-by: Huanpo Lin <robertlin@chromium.org>
Owners-Override: Robert Lin <robertlin@google.com>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280074}