routes: fix open redirect vulnerability #5364 (#5365)

gogs · Aug 6, 2018 · 1f247cf · 1f247cf
1 parent c9bb33a
commit 1f247cf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/routes/user/auth.go b/routes/user/auth.go
@@ -73,10 +73,10 @@ func AutoLogin(c *context.Context) (bool, error) {
 }
 
 // isValidRedirect returns false if the URL does not redirect to same site.
-// False: //url, http://url
+// False: //url, http://url, /\url
 // True: /url
 func isValidRedirect(url string) bool {
-	return len(url) >= 2 && url[0] == '/' && url[1] != '/'
+	return len(url) >= 2 && url[0] == '/' && url[1] != '/' && url[1] != '\\'
 }
 
 func Login(c *context.Context) {