bug #4563 [security] XSS in monitor query analyzer

Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
phpmyadmin · Oct 18, 2014 · a150ea1 · a150ea1
1 parent 57594fe
commit a150ea1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -3,6 +3,7 @@ phpMyAdmin - ChangeLog
 
 4.0.10.5 (not yet released)
 - bug #4562 [security] XSS in debug SQL output
+- bug #4563 [security] XSS in monitor query analyzer
 
 4.0.10.4 (2014-10-01)
 - bug #4544 [security] XSS vulnerabilities in table search and table structure pages

diff --git a/js/server_status_monitor.js b/js/server_status_monitor.js
@@ -1991,7 +1991,7 @@ AJAX.registerOnload('server_status_monitor.js', function() {
                 case 'user_host':
                     return value.replace(/(\[.*?\])+/g, '');
             }
-            return value;
+            return escapeHtml(value);
         };
 
         for (var i = 0, l = rows.length; i < l; i++) {
@@ -2144,7 +2144,7 @@ AJAX.registerOnload('server_status_monitor.js', function() {
             for (var i = 0, l = data.explain.length; i < l; i++) {
                 explain += '<div class="explain-' + i + '"' + (i>0? 'style="display:none;"' : '' ) + '>';
                 $.each(data.explain[i], function(key, value) {
-                    value = (value == null)?'null':value;
+                    value = (value == null)?'null': escapeHtml(value);
 
                     if (key == 'type' && value.toLowerCase() == 'all') {
                         value = '<span class="attention">' + value + '</span>';