bug #4488 [security] XSS injection due to unescaped table name (trigg…

…ers) Signed-off-by: Marc Delisle <marc@infomarc.info>
phpmyadmin · Jul 17, 2014 · 511c596 · 511c596
1 parent d143c54
commit 511c596
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,6 +1,9 @@
 phpMyAdmin - ChangeLog
 ======================
 
+4.1.14.2 (2014-07-17)
+- bug #4488 [security] XSS injection due to unescaped table name (triggers)
+
 4.1.14.1 (2014-06-21)
 - bug #4464 [security] XSS injection due to unescaped db/table name in navigation hiding
 

diff --git a/libraries/rte/rte_list.lib.php b/libraries/rte/rte_list.lib.php
@@ -259,9 +259,9 @@ function PMA_TRI_getRowForList($trigger, $rowclass = '')
     $retval .= "            </td>\n";
     if (empty($table)) {
         $retval .= "            <td>\n";
-        $retval .= "                <a href='db_triggers.php?{$url_query}"
-                                     . "&amp;table={$trigger['table']}'>"
-                                     . $trigger['table'] . "</a>\n";
+        $retval .= "<a href='db_triggers.php?{$url_query}"
+            . "&amp;table=" . urlencode($trigger['table']) . "'>"
+            . urlencode($trigger['table']) . "</a>";
         $retval .= "            </td>\n";
     }
     $retval .= "            <td>\n";