Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Roll Skia from 4aa03c55a0a2 to 222a354c3b4c (2 revisions)
https://skia.googlesource.com/skia.git/+log/4aa03c55a0a2..222a354c3b4c
2024-04-26 michaelludwig@google.com [graphite] Assume sources are already instantiated in copies
2024-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e65031c8b1d6 to 736920240f0b (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jvanverth@google.com
Change-Id: I30919d6c3f61afc9738ae743d480dfa90dcc0a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494125
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293017}
Temporarily disable tests to land frontend changes
Bug: 325441197
Change-Id: I5c898900be0727f6d1ceea1d514c8fc2e660dafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494086
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293016}
Import wpt@72fa84723dc77b424e7ce7517f5749561cc36b67
https://github.com/web-platform-tests/wpt/compare/03304b662...72fa84723
Using wpt-import in Chromium 8bbef49b208dddeb9c127b7d70e488fa08621ca3.
With Chromium commits locally applied on WPT:
e6bcf2963a "webnn: Migrate slice validation tests to WPTs"
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
japhet@chromium.org:
external/wpt/fetch
smcgruer@chromium.org:
external/wpt/css/css-position
NOAUTOREVERT=true
R=rubber-stamper@appspot.gserviceaccount.com
No-Export: true
Validate-Test-Flakiness: skip
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I869c4abdc2a4261b074946ef7d914c58d0a8ba50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490963
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293015}
[Autofill] Fix handling of non-alphanumeric chars in label detection
This CL fixes bugs related to the filtering of label candidates. There
are three checks:
1. Is the string empty? --> No candidate.
2. Is the string empty after whitespace removal? --> No candidate.
3. Does the string falsify IsLabelValid()? --> No candidate.
The problem is that different places in the code use different checks.
For example, applying the InferLabelFromDivTable() heuristic to
<div><div>Name</div><div>:</div><div><input></div></div
first looks for a non-empty label candidate and finds ":", but
then rejects that because it doesn't satisfy IsLabelValid().
As a result, the heuristic finds no label.
This CL merges the three above conditions into one, so that the code
consistently uses the same candidate check.
Thus, in the above example, the loop in InferLabelFromDivTable()
finds "Name".
Moreover, this CL fixes the inconsistency that IsLabelValid() treated
" " (U+0020, space) different from other whitespace characters.
For example, the text content of
<div> </div>
falsified IsLabelValid() but the text content of
<div>
</div>
satisfied IsLabelValid(). It seems that this had no effect because
most callers had trimmed the whitespace beforehand.
Bug: 336508773
Change-Id: Ib1881c8379fb2dfdb65d7714aecd3d9bd1b8fb27
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478148
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Auto-Submit: Christoph Schwering <schwering@google.com>
Reviewed-by: Dominic Battre <battre@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293014}
Make the managed profile notice responsive and work on small screens
Small version: http://screen/3pmyAVNeqpDy5Vz
Medium version: http://screen/7zHNyuVdPsqNQjB
Big version: http://screen/5ooquvgSDhQdsor
Bug: 332735128,335639538
Change-Id: Id700a9419aad378b459d3a62181ebe01394da5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484786
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293013}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1714111179-574e30222dd8007cd779f218c0481a6be8098aa7-43e1c033efba47e52276fa8c8e1e9cc99d69ea98.profdata to chrome-win-arm64-main-1714132703-68f3645302338538f81b155701e509559b279394-3303aa6cb857cf484312124f4a408d31a51ff27d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I99958da205bf235ce51aba2df4970d91ffdf3254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493862
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293012}
Add TODO for removing Gaia Id migration on Ash
Bug: 336833248
Change-Id: I0b074bdea65e2170c6b9fba36fab08fc36045ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484031
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1293011}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1714111179-73eaf4a088a40600b059afee437c24779ac825c4-43e1c033efba47e52276fa8c8e1e9cc99d69ea98.profdata to chrome-win32-main-1714121834-b5b89dbf7ec2bfb1d1ac1de5e9fff42330691781-8ac23a5dbb02c5d238cf8b2d568a933c09c332b3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Iab34d5d1182edebd9c91d008c662104944301ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494048
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293010}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1714125327-f74600205e9457a821d96bfa734f097fdd132532-2b1c69977628a378098bd4af82585163a373265c.profdata to chrome-android64-main-1714132703-1da7b9973ec0219d1c12a7e13df108f67bc3a877-3303aa6cb857cf484312124f4a408d31a51ff27d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ic0968f0e2046179446ab44436b939578e65b95e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494060
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293009}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1714089620-502a3e95920a152416d3f2e8aa196f1b8267d5f5-23eac880d39cc58f51a9b7dc36397af6df151fde.profdata to chrome-chromeos-amd64-generic-main-1714132703-7b040fbbeef281e9dcb90519c372475224f9ed38-3303aa6cb857cf484312124f4a408d31a51ff27d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie0575849ea8e024751591d8d592f004e9ba45cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493537
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293008}
[Viz] Remove legacy mailbox handling
Here we remove remaining handling of legacy mailboxes in
//components/viz and annotate the calls of Mailbox::IsSharedImage() that
need to stay because they are for differentiating software SIs from
shared bitmaps.
Bug: 40057997
Change-Id: I4fc40d10a1da5cf8aeebb42a355602a03808254d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491241
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293007}
[//gpu] Remove IS_CAST_ANDROID setting `chromium_image_ycbcr_420v`
Having `chromium_image_ycbcr_420v` be set on IS_CAST_ANDROID is both
a no-op and meaningless:
* It is a no-op because
`supported_buffer_formats_for_allocation_and_texturing` is left at
its empty value, meaning that `chromium_image_ycbcr_420v` will always
stay at its default value of false
* It is meaningless because IS_CAST_ANDROID implies IS_ANDROID, and this
flag is only used by GMBVideoFramePool, which is not instantianted on
Android.
It is likely that the setting here was an unintentional side effect of
splitting of one CAST buildflag into multiple back in the depths of
time (e.g., see discussion in [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3687578/comment/e327ac36_c96effd3/
Bug: 40283225
Change-Id: I1b4183c7b1ba47846b243f1259f34a68152f0425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491244
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293006}
[iOS] Move snapshot when moving tab to another window's group
This CL makes sure that when a tab is moved to a group in another window
the tab's snapshot is also moving to the other browser.
Fixed: 337193404
Change-Id: Ie70d56948833880ce15106e21137f2c9e7397398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493820
Commit-Queue: Louis Romero <lpromero@google.com>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293005}
[mullhet] Make IsEmpty() return info about autofillable credentials
`LoginDatabase::IsEmpty` now returns a struct which contains 2 booleans:
- `no_login_found`, which is true if the login database has no passwords
- `autofillable_credentials_exist`, which is true if the login database
has any autofillable logins. Autofillable logins are the ones with non-
empty password value.
Entries which are not autofillable (have empty password value) are:
blocklisted entries, federated credentials and username-only credentials
The additional information about whether autofillable credentials exist
is used to decide whether the passwords context menu entry can be
displayed.
Bug: 321678141
Change-Id: Ic9fdd661432b2e079d5a9b08549119bf892f9a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465561
Commit-Queue: Theo Cristea <theocristea@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bruno Braga <brunobraga@google.com>
Cr-Commit-Position: refs/heads/main@{#1293004}
Prepare determine_possible_field_types tests to enable i18n data model.
Bug: b/325027274
Change-Id: I648f97883c6a90e2737d20c38d46c359b3981345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494085
Commit-Queue: Norge Vizcay <vizcay@google.com>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1293003}
Respond with invalid selector error
This commit fixes a regression due to which ChromeDriver responded with
"javascript error" to retrieval requests with invalid location strategy.
Bug: chromedriver:4743
Change-Id: I7eab6fc148682c3bde63761ef234a1940ad55a79
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490662
Auto-Submit: Vladimir Nechaev <nechaev@chromium.org>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Commit-Queue: Vladimir Nechaev <nechaev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293002}
Revert "Remove kForYouFre feature flag check from startup_browser_creator_impl"
This reverts commit 581b3bcc73f58b34cb5981bf493b42bbd3df6732.
Reason for revert: Test still failing. Reverting parent change as well. Suspected to break AppControllerOpenShortcutBrowserTest.OpenShortcutOnStartup on https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests/12077/overview
The tests expects the welcome page to be displayed.
Original change's description:
> Remove kForYouFre feature flag check from startup_browser_creator_impl
>
> The feature is now fully launched. This is part of the cleanup process.
>
> Fixed: b:336748320
> Change-Id: I266165b68d2e0035833251403e6b2479d22f0b62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481574
> Auto-Submit: Jack Yammine <jyammine@google.com>
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Roger <droger@chromium.org>
> Commit-Queue: Jack Yammine <jyammine@google.com>
> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1292915}
Change-Id: I6b434e97fcd621df6e7e2916675ae923e07ba577
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490229
Owners-Override: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1293001}
Remove pmarko from OWNERS in /components/proxy_config
My open source capactiy will be lower than my @google.com capacity, so
accounting for that.
This CL was uploaded by git cl split.
R=stevenjb@chromium.org
Bug: none
Change-Id: Id87c38327d89df925f2e9ae188c4226cd52886e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485947
Auto-Submit: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Andreea Costinas <acostinas@google.com>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293000}
Do not let textarea controller become dangling in ContentAnalysisDialog.
The ContentAnalysisDialog (as a views::DialogDelegate) is destroyed
prior to its content view. As a result, the pointer to the controller
of the textarea in the content view becomes dangling.
This CL unsets the controller in the ContentAnalysisDialog destructor.
The aim of this CL is to eventually mark the Textfield::controller_
member as not dangling.
Bug: 40277363
Change-Id: I08cfa75af9b0399888befc392e668739a9c409d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481796
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Sébastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Sébastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292999}
Add close button to auth panel
Bug: b:271248452
Change-Id: I401e3fe0c5052616874258d368f1cedbd64f9f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471824
Commit-Queue: Elie Maamari <emaamari@google.com>
Reviewed-by: Istvan Nagy <iscsi@google.com>
Cr-Commit-Position: refs/heads/main@{#1292998}
Include-what-you-use in c/b/a/login/saml/
Generated with:
gn gen out/Debug --export-compile-commands
clang_tidy -fix-errors -checks="-*,misc-include-cleaner" \
-p out/Debug/commands.json chrome/browser/ash/login/saml/?(*.cc|*.h)
git cl format (to fix newlines)
Manual steps:
- fixing some incorrect includes (gtest, gmock and some *pb.h files)
- replacing newly added includes with forward declarations where it is
obvious
Inspired by https://crrev.com/c/5490221.
Bug: None
Change-Id: Iac733377698c824ba7f6482ec99f8df57143730f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490281
Reviewed-by: Roland Bock <rbock@google.com>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Andrey Davydov <andreydav@google.com>
Cr-Commit-Position: refs/heads/main@{#1292997}
Roll clank/internal/apps from 18f62c923824 to 8dc5e7d7aebc (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/18f62c923824..8dc5e7d7aebc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,kraskevich@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kraskevich@google.com
No-Try: true
Change-Id: I7f58ef78264e20da3cdfc3b656c7cb3910f9a2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492744
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292996}
Enable ButterOnDesktopFollowups flag in tests for lacros
Bug: 40943570
Change-Id: I3cb50c0788af71d3563c5943858d1669acc602fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490226
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Karol Sygiet <sygiet@google.com>
Cr-Commit-Position: refs/heads/main@{#1292995}
base/hash: apply clang-tidy's misc-include-cleaner
Bug: 336474469
Change-Id: I908b7c7ec5f0d70dfb7084893f447e8285a57820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492824
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292994}
[iOS] Include the group title and color directly in the grid
See video:
https://drive.google.com/file/d/1xmbJNphAPBG30KpSGNuquNoL-p9fT0fa/view?usp=drive_link
See also when the title is updated:
https://drive.google.com/file/d/1Xe16MFbtWUwM1jw7x_JF8Y7cSJUrZTqF/view?usp=drive_link
Bug: 334887476
Change-Id: I3b77c4acd61a03465ef41f252ed5c95614a43be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488000
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292993}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1714111179-917ab93bfedb8bbc30b3044846db052e6fbcdd59-43e1c033efba47e52276fa8c8e1e9cc99d69ea98.profdata to chrome-win64-main-1714121834-9e810a3a4edc208f3d3933611121a028175d6e59-8ac23a5dbb02c5d238cf8b2d568a933c09c332b3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6440fa85242a97ab9f5eaecbdc9135aad3c90b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493900
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292992}
[ios] Extent IOS.ExperienceKitCalendar.Success
Bug: 40903841
Change-Id: I47dd98fa3b7cf042893edafb43678721e95973bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472403
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292991}
Cleanup PWM flags
NewConfirmationBubbleForGeneratedPasswords was launched and flag
metadata is no longer needed.
RestartToGainAccessToKeychain will be still used to try launching
this feature again on Linux, so it's expiry_milestone will increase.
Bug: 335245342
Change-Id: I106a242c9593b125498868e86cd2373def4c5363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493660
Commit-Queue: Karol Sygiet <sygiet@google.com>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1292990}
kiosk: Move KioskSystemSession ownership to KioskController
KioskSystemSession is currently owned by web and Chrome app kiosk
managers (I don't know why but KioskSystemSession is not initialized in
ARC). This change moves ownership from the app managers to
KioksController. Other than that it doesn't change any logic.
This also fixes includes in touched files.
Bug: b:322301742
Test: tast run DUT "kiosk.Smoke.*"
Change-Id: I5f0f1dca3d3ebaa2f68b4c6a844fa48af9766edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490101
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Edman Anjos <edman@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/main@{#1292989}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1714111179-1ba0a800877f563a77e30bb8147cfd23bcb28428-43e1c033efba47e52276fa8c8e1e9cc99d69ea98.profdata to chrome-android32-main-1714132703-1b4b4f94fd20b3a3ec0f0150122136377b27722c-3303aa6cb857cf484312124f4a408d31a51ff27d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If6779b339f32c2280bfb012bf270cc9e50f71995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493903
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292988}
Disable flaky SyncConfirmationUIDialogPixelTest
Bug: 336964850
Change-Id: I0771498f77e0c75d549a25865444d37ea39cfe8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491246
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Owners-Override: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Mariam Ali <alimariam@google.com>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Zaina Al-Mashni <zalmashni@google.com>
Commit-Queue: Zaina Al-Mashni <zalmashni@google.com>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Commit-Queue: Mariam Ali <alimariam@google.com>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292987}
Disable flaky ArcRobotAuthCodeFetcherBrowserTests
Bug: 41494522
Change-Id: Ia491030030682a6a251b39fd97ba27d905fb831c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494084
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Owners-Override: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292986}
[iOS] Add animation to make the more button disappear
When the user taps on the more pill button, or the scroll view reaches
the bottom, the more pill button needs to move down to disappear.
Tap on the more pill button:
https://drive.google.com/file/d/1MMLqA8OubkZ8PK7ZcKm9pDg8GKp_ZVbk/view?resourcekey=0-Mv0wU8pmFd6zrIhMJhLnOw
Scroll down the view:
https://drive.google.com/file/d/1ePIg_5Uz2fQIEQboYhJX3yRfbXTYa6Le/view?resourcekey=0-3rw2Y7v0AjgdzAeBf8OgyA
Fixed: 337180864
Change-Id: Ib440e093511d64a997d57b7749f0589fdff68654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493659
Reviewed-by: Louis Romero <lpromero@google.com>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292985}
Correctly apply cached clipboard request verdicts
This CL handles the `is_complete()` early return in
`PasteAllowedRequest::StartPasteAllowedRequest` properly by actually
checking the cached data and whether it's allowed instead of just
allowing it.
This CL also updates `ClipboardPasteData::Merge` to allow copied values
to be passed to it instead of just r-values as that is required by
`PasteAllowedRequest::InvokeCallback`.
Bug: 336832453
Change-Id: I91ee53c72514a4323acdc09a6a902117e3fb267a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491619
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Nancy Xiao <nancylanxiao@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292984}
Null-check View() when responding to a resize
This is a defensive fix for a crash found in the wild.
Bug: 335654142
Change-Id: Ic12f5d1dc1fdc31eac7ed1e0888ea6c04bfb0169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482188
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292983}
Roll Projector App from FvRDySBjbZ8HP9M6u... to IvcRNBLCRWqAF94NB...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202404260100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/IvcRNBLCRWqAF94NB9Xne5JYrb_It_vC9Ma5JeCCZBAC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC cros-projector-oncall@grotations.appspotmail.com,cros-projector@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/329426836,b/329427795,b/329428012,b/329428948
Tbr: cros-projector-oncall@grotations.appspotmail.com
Change-Id: I2ed3b5bd38edaed5d0bf925087f8fc95bfae8eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493155
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292982}
Roll R8 from vLf3kX0m10K0jItyl... to 7sVFkxumsokMdM4Ma...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC clank-build@google.com,clank-library-failures@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: clank-library-failures@google.com
Change-Id: I5901507b5f9129a627758c772e35b5dce035e9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493534
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292981}
Roll devtools-internal from 0bed377e1ed9 to 12e5611b2e6a (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/0bed377e1ed9..12e5611b2e6a
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1226a4183f55a47a7b8011f0674edb3cf5668ce6..51ae7ec351004f86ffe1355af2436c1b58eb6e6f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I9c8fbefbc75d30482a939ed78b8612a2bfa96ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492518
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292980}
Remove unused tracked labels
This method/member was only used in the old UI. As a possible next step,
we can consider getting rid of the class altogether.
Bug: b/335194240
Change-Id: I923fae6978d7897e884e33072bcaeec0e2d19732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463584
Commit-Queue: Bruno Braga <brunobraga@google.com>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1292979}
[UPMLocalPwd] Don't offer GMSCore update message without Play Store
Add a method that checks for presence of Play Store on the device
before offering to update GMS Core.
Bug: b/336281755
Change-Id: Ic1657d4ba8f87e93de0f53e1004a6721a9778a35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481990
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ivana Žužić <izuzic@google.com>
Cr-Commit-Position: refs/heads/main@{#1292978}
Revert "Remove kForYouFre feature flag check from profile_customization_util.cc"
This reverts commit 307508b3208fd7ceb4507b5679e021b73c74afc9.
Reason for revert: Suspected to break AppControllerOpenShortcutBrowserTest.OpenShortcutOnStartup on https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests/12077/overview
The tests expects the welcome page to be displayed.
Original change's description:
> Remove kForYouFre feature flag check from profile_customization_util.cc
>
> The feature is now fully launched. This is part of the cleanup process.
>
> Fixed: b:336721302
> Change-Id: I2cc93653000be95b35bf9b37ee34ea9c4f68d762
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482108
> Auto-Submit: Jack Yammine <jyammine@google.com>
> Commit-Queue: Jack Yammine <jyammine@google.com>
> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1292906}
Change-Id: Ib231863aac1e2641848abe54e1d7e4c8f630f83c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494066
Owners-Override: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292977}
[iOS] Move browser_util to web_state_list folder
This util file is mostly about moving tabs, so it makes more sense for
it to be with web_state_list files.
Bug: 337193404
Change-Id: Ib56862d5c76488895b64d97762accc45b6f66c7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490284
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Louis Romero <lpromero@google.com>
Reviewed-by: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1292976}
Add field trial config for WebViewUseInitialNetworkStateAtStartup
A study that enables using the initial network state at WebView startup, that should eliminate two duplicate binder calls in WebView startup.
Bug: 323018667
Change-Id: Id203ad933690e2d5722f982351aafa095e8daba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491199
Auto-Submit: Sayed Elabady <elabadysayed@chromium.org>
Reviewed-by: Wayne Jackson Jr. <wbjacksonjr@chromium.org>
Commit-Queue: Wayne Jackson Jr. <wbjacksonjr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292975}
Return unsupported operation error on Android
The commands Maximize Window, Minimize Window and Fullscreen Window are
not supported by the browser on Android. With this commit ChromeDriver
will return the standard compliant "unsupported command" error in
response to these commands on Android.
Bug: chromedriver:4689
Change-Id: I41b6f64dae33209d422609d81e8a19893013a0c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490224
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Auto-Submit: Vladimir Nechaev <nechaev@chromium.org>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292974}
[iOS] Clean up unused enableBookmarkAndReadingListAccountStorageOptIn
This method is not needed anymore, as new logic was introduced using the
PostSignInActions.
Bug: 41488185
Change-Id: I62fcf77e23b1d1de57ab6684b174f3c84db9dd43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490680
Commit-Queue: Jood Hajeer <jood@google.com>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292973}
Simplify autofill popup margins and clean up unnecessary code.
1. Improve method names and documentation to make it more explicit where
autofill popup margins are coming from and why they are set.
2. Remove unnecessary has_control param from
popup_cell_utils::GetMarginsForContentCell
3. Remove padding method from the popup base class.
Bug: b/335194240, 40254722
Change-Id: I135853c70887bce7df2d2a90a2b0901df74ec266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490105
Commit-Queue: Bruno Braga <brunobraga@google.com>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1292972}
[Passwords][WebAuthn] Run passkeySelectedCallback when appropriate
ChromeWebAuthnCredentialsDelegate is responsible for dismissing the
autofill popup when a passkey is selected in PasswordAutofillManager.
This CL observes AuthenticatorRequestDialogModel's state changes.
AutofillPopup will be dismissed (via OnPasskeySelectedCallback) if any of the following happens:
- the ui is not disabled
- Conditional request is completed.
This will be only done for the enclave passkeys.
Current impl: go/scrcast/NTEwOTk1NDU3Mzc2MjU2MHxmMmU1MjJjZS1iMg
Followup CLs will disable the rows in the popup and show a loading
spinner.
Bug: 40274370
Change-Id: Ib3ef11ad9a568abac2d9bc26a99c2a355206c624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387880
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Adem Derinel <derinel@google.com>
Cr-Commit-Position: refs/heads/main@{#1292971}
Default enable Autofill popup improved timing checks.
To allow default-enabling the improved timing checks, this CL:
- makes the time measurement in the SetViewForTesting mimic the one
in production code,
- removes expectations for metrics that are no longer emitted.
It also extends the expiration date for a metric that will be removed
once the feature is cleaned up.
Bug: 40279821
Change-Id: I48f09f76252ac8fd402f98a3b77f9824a59c0241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5489202
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1292970}
Disable flaky SwitchAccessItemScanManagerTest.ScanAndTypeVirtualKeyboard test
Bug: 336827654
Change-Id: I42b38b3c6163816b8c04a4c0ced9cbae71a3e52a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493783
Owners-Override: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292969}
.clang-tidy: exclude some headers from misc-include-cleaner
This is to prevent insertion of include paths which don't start from
repository root.
This doesn't enable misc-include-cleaner check, but it is useful when we
apply clang-tidy to existing files.
Bug: 336474469
Change-Id: I0fb1c33aba71fa6a2032bd724ab303d23d2ba981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493007
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292968}